Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rdsn): remove 'include' directory in rdsn #1189

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Oct 18, 2022

#1053

This patch is aim to make rdsn as a real part of Pegasus, not act as a public library, including the following changes:

  1. remove ${DSN_ROOT} from build enviroment, and use ${BUILD_DIR}/output instead.
  2. move header files from src/rdsn/include to the place where they should be, for example src/rdsn/src/utils, src/rdsn/src/runtime, and etc.
  3. update '#include' macros to the new header place as mentioned above.
  4. update .licenserc.yaml and LICENSE for the related files.
  5. update scripts/compile_thrift.py and scripts/recompile_thrift.sh.

TODO:

  1. The included header files are unordered and may be duplicated, I', planning to use IWYU to optmize it.
  2. The C++ client shared lib is not exported now, it have to be exported later.

@empiredan empiredan merged commit d3e9cb8 into apache:master Oct 18, 2022
@acelyc111 acelyc111 mentioned this pull request Oct 19, 2022
10 tasks
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants