server: support check_and_set #122

qinzuoyan · 2018-07-13T10:55:09Z

No description provided.

neverchanje · 2018-07-16T02:23:16Z

这个功能是为了解决现有什么需求的？
我们只需要 checkAndSet 吗？如果以后需要 checkAndDelete 或者 checkAndMultiSet 如何扩展？我建议可以借鉴 hbase 的 checkAndMutate 接口，这个接口更通用。 http://hbase.apache.org/apidocs/src-html/org/apache/hadoop/hbase/client/Table.html#line.477

qinzuoyan · 2018-07-16T13:54:31Z

因为wifi万能钥匙那边有需求。另外check_and_set是比较基本的原子操作，以后做transaction等都需要依赖这个功能。
现在确实只支持set一个值。你说的checkAndMutate我也考虑过，不过接口会复杂一些，我准备在以后有需求的时候一起加，同时还增加直接的mutate（不check）。在Mutation中可以放入多个set和del操作，因为现在的multiSet和multiDel无法同时set和del。
所以现在这个版本算是一个基础版吧。mutate因为对客户端接口改动较大，以后有需求再加。

acelyc111 · 2018-07-14T01:21:15Z

src/client_lib/pegasus_client_impl.cpp

+    req.check_sort_key.assign(check_sort_key.c_str(), 0, check_sort_key.size());
+    req.check_type = (dsn::apps::cas_check_type::type)check_type;
+    req.check_oprand.assign(check_oprand.c_str(), 0, check_oprand.size());
+    if (check_sort_key != set_sort_key) {


相同的时候就不用给req.set_sort_key赋值吗？

acelyc111 · 2018-07-14T01:29:39Z

src/idl/recompile_thrift.sh

 sed 's/#include "rrdb_types.h"/#include <rrdb\/rrdb_types.h>/' $TMP_DIR/rrdb_types.cpp > ../base/rrdb_types.cpp

 rm -rf $TMP_DIR

+echo
+echo "You should manually modify these files:"


没看懂这个是什么意思？

因为这三个文件的代码都是手写的（有些特殊的定制规则），所以不能使用thrift生成的文件。

acelyc111 · 2018-07-14T02:20:31Z

src/include/pegasus/client.h

@@ -99,6 +99,48 @@ class pegasus_client
        }
    };

+    enum cas_check_type


这个也可以直接使用thrift里面生成的吧？

我们的Pegasus客户端头文件要尽量少依赖，所以不要依赖thrift的头文件

shengofsun · 2018-07-17T03:57:08Z

src/server/pegasus_write_service_impl.h

+        case ::dsn::apps::cas_check_type::CT_VALUE_BYTES_GREATER: {
+            if (!value_exist)
+                return false;
+            int c = dsn::string_view(value).compare(dsn::string_view(check_operand));


我们的binary_compare是不是也可以顺手删了

shengofsun · 2018-07-17T04:02:37Z

src/server/pegasus_write_service_impl.h

+    // return true if check passed.
+    // for int compare, if check operand or value are not valid integer, then return false,
+    // and set out param `invalid_argument' to false.
+    bool validate_check(int64_t decree,


这种函数能不能单独抽出来写单元测试，而不是通过集成测试的方式来做。

构造context比较麻烦，现在的测试已经比较全面了

shengofsun · 2018-07-17T04:04:51Z

src/shell/commands.h

@@ -40,24 +40,102 @@ inline bool version(command_executor *e, shell_context *sc, arguments args)
    return true;
 }

+#define NAME_EQUAL(name) ((len = strlen(name)) == length && strncmp(buffer, name, len) == 0)


统一用string view的compare?

shengofsun · 2018-07-17T04:09:58Z

src/shell/commands.h

+inline bool
+buf2cas_check_type(const char *buffer, int length, pegasus::pegasus_client::cas_check_type &result)
+{
+    int len = 0;


这个地方可以用enum_helper吗？或者commond_utils.h下的type_from_string有没有帮助？这么写略琐碎

不能，还是那个问题，pegasus client头文件依赖要简单，不要依赖rdsn的头文件。

commands.h不用担心依赖的问题的

Former-commit-id: b7b7ec6b9134d4ac0acdde7971d975f5adee22e0 [formerly 4c8e64f] Former-commit-id: 18d00bce2280b67135699e4c55b91c3b25b5feaa

…potent_write in replication option (#122)

qinzuoyan added the new feature label Jul 13, 2018

qinzuoyan requested review from shengofsun, neverchanje and acelyc111 July 13, 2018 10:55

*: support check_and_set

a31d630

qinzuoyan force-pushed the qinzuoyan2 branch from 4e25f18 to a31d630 Compare July 17, 2018 03:50

acelyc111 reviewed Jul 17, 2018

View reviewed changes

shengofsun reviewed Jul 17, 2018

View reviewed changes

qinzuoyan added 4 commits July 17, 2018 13:34

smallfix

dfc7ced

smallfix

87b7723

smallfix

a728e9e

smallfix

1e828ca

shengofsun approved these changes Jul 17, 2018

View reviewed changes

acelyc111 approved these changes Jul 17, 2018

View reviewed changes

qinzuoyan merged commit 4c8e64f into master Jul 17, 2018

qinzuoyan deleted the qinzuoyan2 branch July 17, 2018 11:31

neverchanje added component/api pegasus client interfaces and removed new feature labels Sep 13, 2018

neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019

server: support check_and_set (apache#122)

ab8a807

Former-commit-id: b7b7ec6b9134d4ac0acdde7971d975f5adee22e0 [formerly 4c8e64f] Former-commit-id: 18d00bce2280b67135699e4c55b91c3b25b5feaa

acelyc111 pushed a commit that referenced this pull request Jun 23, 2022

replication: add is_idempotent attr for task code; add allow_non_idem…

8f0ff15

…potent_write in replication option (#122)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: support check_and_set #122

server: support check_and_set #122

qinzuoyan commented Jul 13, 2018

neverchanje commented Jul 16, 2018

qinzuoyan commented Jul 16, 2018

acelyc111 Jul 14, 2018

acelyc111 Jul 14, 2018

qinzuoyan Jul 17, 2018

acelyc111 Jul 14, 2018

qinzuoyan Jul 17, 2018

qinzuoyan Jul 17, 2018

shengofsun Jul 17, 2018

qinzuoyan Jul 17, 2018

shengofsun Jul 17, 2018

qinzuoyan Jul 17, 2018

shengofsun Jul 17, 2018

qinzuoyan Jul 17, 2018

shengofsun Jul 17, 2018 •

edited

Loading

qinzuoyan Jul 17, 2018

shengofsun Jul 17, 2018 •

edited

Loading

server: support check_and_set #122

server: support check_and_set #122

Conversation

qinzuoyan commented Jul 13, 2018

neverchanje commented Jul 16, 2018

qinzuoyan commented Jul 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shengofsun Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shengofsun Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

shengofsun Jul 17, 2018 •

edited

Loading

shengofsun Jul 17, 2018 •

edited

Loading