Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the corruption RocksDB instance will be reused bug #1422

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Mar 30, 2023

#1383

This patch deal with the error kCorruption returned from storage
engine of write requests. After replica server got such an error,
it will trash the replica to a trash path
<app_id>.<pid>.pegasus.<timestamp>.err.
Note that the replica server may crash because the corrupted replica
has been trashed and closed, it is left to be completed by another
patches.

@acelyc111 acelyc111 marked this pull request as ready for review April 4, 2023 16:49
@empiredan empiredan merged commit 9303c3a into apache:master Apr 11, 2023
@empiredan empiredan mentioned this pull request Aug 21, 2023
GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Feb 28, 2024
…apache#1422)

对应社区commit: https://github.com/apache/incubator-pegasus/pull/1422/files

其中,单测 integration_test.cpp 未添加,原因是整个function test的变更过大不便添加,等
最后都合入后再单独补充

apache#1383

This patch deal with the error `kCorruption` returned from storage engine of
write requests. After replica server got such an error, it will trash the
replica to a trash path `<app_id>.<pid>.pegasus.<timestamp>.err`.

Note that the replica server may crash because the corrupted replica has been
trashed and closed, it is left to be completed by another patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants