fix(ddl_client): sleep for a while before retry once meta server is busy #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceiving ERR_BUSY_* from meta server
…ceiving ERR_BUSY_* from meta server
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
acelyc111
reviewed
Apr 18, 2023
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
acelyc111
reviewed
Apr 19, 2023
levy5307
reviewed
Apr 20, 2023
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
…NG sleep for a while before retry
empiredan
changed the title
acelyc111
reviewed
Apr 24, 2023
acelyc111
approved these changes
Apr 24, 2023
levy5307
approved these changes
Apr 25, 2023
Closed
empiredan
added
the
type/config-change
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
…erver is busy https://jira.sensorsdata.cn/browse/SKV-618 社区issue：apache#1449 社区pr：apache#1453 Under some circumstances, creating/dropping table might spend more time, which could even be greater than RPC timeout. Then, once DDL client launched another requests to meta server, it would receive `ERR_BUSY_CREATING` or `ERR_BUSY_DROPPING`. Between these two attempts there is no interval, thus these attempts are ineffective. Therefore, a retry mechanism is introduced to resolve this problem: - the max number of attempts is configurable; - the retry mechanism for failed sending request to meta server due to `ERR_NETWORK_FAILURE` or `ERR_TIMEOUT` is unchanged, and the max number of attempts is restrict by the configuration; - once response is `ERR_BUSY_CREATING` or `ERR_BUSY_DROPPING`, DDL client would also retry, and between two attempts there is an configurable interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1449
Under some circumstances, creating/dropping table might spend more time,
which could even be greater than RPC timeout. Then, once DDL client launched
another requests to meta server, it would receive
ERR_BUSY_CREATINGorERR_BUSY_DROPPING. Between these two attempts there is no interval, thusthese attempts are ineffective.
Therefore, a retry mechanism is introduced to resolve this problem:
ERR_NETWORK_FAILUREorERR_TIMEOUTis unchanged, and the maxnumber of attempts is restrict by the configuration;
ERR_BUSY_CREATINGorERR_BUSY_DROPPING, DDLclient would also retry, and between two attempts there is an configurable
interval.
Some new configurations are added: