rproxy: add incr/incrby/decr/decrby #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
reviewed
Jul 25, 2018
qinzuoyan
previously approved these changes
Jul 27, 2018
neverchanje
reviewed
Jul 27, 2018
| @@ -938,6 +942,104 @@ void redis_parser::geo_radius_by_member(message_entry &entry) | |||
| hash_key, "", radius_m, count, sort_type, 2000, search_callback); | |||
| } | |||
|
|
|||
| void redis_parser::incr(message_entry &entry) { counter_internal(entry); } | |||
There was a problem hiding this comment.
这里不用加注释，因为函数名本身就是自解释的。其他有的加了注释是因为跟redis原生命令有些出入
neverchanje
reviewed
Jul 27, 2018
| return; | ||
| } | ||
| } else { | ||
| dassert(false, "command not support"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@shengofsun INC已添加, CHECK_AND_SET目前rproxy还没使用，暂时不加吧 |
qinzuoyan
previously approved these changes
Jul 27, 2018
qinzuoyan
previously approved these changes
Jul 27, 2018
shengofsun
reviewed
Jul 28, 2018
| @@ -35,6 +35,7 @@ proxy_stub::proxy_stub(const proxy_session::factory &f, | |||
| dsn::task_spec::get(dsn::apps::RPC_RRDB_RRDB_GET_SCANNER_ACK)->allow_inline = true; | |||
| dsn::task_spec::get(dsn::apps::RPC_RRDB_RRDB_SCAN_ACK)->allow_inline = true; | |||
| dsn::task_spec::get(dsn::apps::RPC_RRDB_RRDB_CLEAR_SCANNER_ACK)->allow_inline = true; | |||
| dsn::task_spec::get(dsn::apps::RPC_RRDB_RRDB_INCR)->allow_inline = true; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
这里主要是看到proxy这块之前也没有针对接口的单测，而那个redis协议的python脚本基本也不起作用（都想删掉的），所以现在都还没加，包括之前的redis geo的单测。 |
qinzuoyan
approved these changes
Jul 29, 2018
shengofsun
approved these changes
Jul 29, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
* add incr/incrby/decr/decrby for redis proxy Former-commit-id: caee216d1b3c842d377b0c6086c3afa9165ed8a8 [formerly 2b92df0] Former-commit-id: a5b375e2b944e927eb9c771b935916c74328ac07
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.