Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change namespace 'dsn' to 'pegasus' WIP #1472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented May 10, 2023

#1053

After the rdsn submodule has been merged into the Pegasus codebase, the previous namespace dsn is still distributed everywhere, they are some type of duplicated, useless and confused.

This patch uses namespace pegasus instead of dsn without any functionality changes, in addition there are some other very little changes, including:

  • Move some FLAGS into the global namesapce, then we can use the FLAGS in any namespace without a namespace prefix.
  • Rename some variables which are also type names. e.g. rename message_header.gpid to message_header.gpid_, rename some local variables from gpid to pid, and etc.
  • Remove function random32 and use utils::next32() instead.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@ee03ffe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7125557 differs from pull request most recent head 1ecb810. Consider uploading reports for the commit 1ecb810 to get more accurate results

@@            Coverage Diff            @@
##             master    #1472   +/-   ##
=========================================
  Coverage          ?   53.58%           
=========================================
  Files             ?       27           
  Lines             ?     2538           
  Branches          ?        0           
=========================================
  Hits              ?     1360           
  Misses            ?     1132           
  Partials          ?       46           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acelyc111 acelyc111 marked this pull request as ready for review May 16, 2023 11:11
levy5307
levy5307 previously approved these changes May 18, 2023
@acelyc111 acelyc111 changed the title refactor: change namespace 'dsn' to 'pegasus' refactor: change namespace 'dsn' to 'pegasus' WIP May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants