feat(Ranger): add a default database policy name for legacy table #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Jun 2, 2023
| dsn::replication::update_app_env_rpc rpc(std::move(req), LPC_USE_RANGER_ACCESS_CONTROL); | ||
| _meta_svc->get_server_state()->set_app_envs(rpc); | ||
| LOG_AND_RETURN_NOT_OK(ERROR, rpc.response().err, "set_app_envs failed."); | ||
| break; |
There was a problem hiding this comment.
Is it possible that a table match multiple policies?
There was a problem hiding this comment.
Yes, next patch will solve this problem: i will add a new data structure to record all matching policies
added 2 commits
June 2, 2023 19:21
acelyc111
previously approved these changes
Jun 6, 2023
acelyc111
previously approved these changes
Jun 7, 2023
empiredan
reviewed
Jun 7, 2023
acelyc111
approved these changes
Jun 8, 2023
empiredan
approved these changes
Jun 8, 2023
Closed
empiredan
added
the
type/config-change
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1054
What is changed and how does it work?
legacy_table_database_mapping_policy_name,the legacy table (the tables which are created before Ranger ACL enabled) will be
matched to the database named
legacy_table_database_mapping_policy_namefor ACL.
A new configuration is added:
[ranger] + legacy_table_database_mapping_policy_name = __default__