server: add check_and_mutate() interface and implementation #161

vagetablechicken · 2018-08-06T09:47:50Z

refer to #159

qinzuoyan · 2018-08-06T10:29:03Z

src/idl/rrdb.thrift

@@ -181,6 +187,38 @@ struct check_and_set_response
    8:string         server;
 }

+struct mutate
+{
+    1:i32            operation;


为什么不直接用 mutate_operation 类型？

qinzuoyan · 2018-08-06T10:29:34Z

src/idl/rrdb.thrift

@@ -40,6 +40,12 @@ enum cas_check_type
    CT_VALUE_INT_GREATER              // int compare: value > operand
 }

+enum mutate_operation
+{
+    PUT,


枚举值加上 MO_ 前缀比较好

qinzuoyan · 2018-08-06T10:30:33Z

src/idl/rrdb.thrift

+    6:bool           return_check_value;
+}
+
+struct check_and_mutate_response


这个可以直接使用 check_and_set_response，不用新增struct了

感觉这个留着好。以后更有可能的是用check_and_mutate把check_and_set给实现了，到时候还是得改。
甚至我们可以更激进一点，趁着check_and_set还没有大规模使用，这个版本就赶紧把check_and_set给换成check_and_mutate

在 XiaoMi/rdsn#149 这个修复提交后，就可以移除 check_and_set，并发布新版本1.11.0 。这样java client 1.10.0在访问server 1.11.0，check_and_set操作不存在，也能返回handle not found的错误码，用户很容易就知道是什么问题，然后升级到java client 1.11.0就可以了。

和伟杰讨论下，还是按照现在的方案，同时保留check_and_set和check_and_mutate两个接口，以保持各个版本间的兼容性。不过在pegasus_write_service的实现里面，这两个函数的实现上绝大部分逻辑都是一样的，尽量将重复的代码合并。

shengofsun · 2018-08-06T12:21:13Z

src/idl/rrdb.thrift

+{
+    1:i32            operation;
+    2:dsn.blob       sort_key;
+    3:dsn.blob       value; 


value和set_expire_ts_seconds可以都改成optional的，这样传delete操作能稍微省点儿空间。加个注释说一下这两个字段对于delete没用

我倒觉得没有必要改成optional，这点空间损耗基本可以忽略。我看其他所有struct也都没有加optional。

没加optional，是考虑到，如果加optional，构造函数就没有“被设为optional的参数”，会使得PUT操作初始化有些奇怪。

shengofsun · 2018-08-06T12:27:58Z

src/idl/rrdb.thrift

+    6:bool           return_check_value;
+}
+
+struct check_and_mutate_response


感觉这个留着好。以后更有可能的是用check_and_mutate把check_and_set给实现了，到时候还是得改。
甚至我们可以更激进一点，趁着check_and_set还没有大规模使用，这个版本就赶紧把check_and_set给换成check_and_mutate

qinzuoyan

去掉check_and_set操作吧

qinzuoyan · 2018-08-08T02:52:55Z

src/idl/rrdb.thrift

+    6:bool           return_check_value;
+}
+
+struct check_and_mutate_response


在 XiaoMi/rdsn#149 这个修复提交后，就可以移除 check_and_set，并发布新版本1.11.0 。这样java client 1.10.0在访问server 1.11.0，check_and_set操作不存在，也能返回handle not found的错误码，用户很容易就知道是什么问题，然后升级到java client 1.11.0就可以了。

qinzuoyan · 2018-08-08T02:54:07Z

src/server/info_collector.cpp

        }
        read_qps[read_qps.size() - 1] = all.get_qps + all.multi_get_qps + all.scan_qps;
        write_qps[read_qps.size() - 1] = all.put_qps + all.multi_put_qps + all.remove_qps +
                                         all.multi_remove_qps + all.incr_qps +
-                                         all.check_and_set_qps;
+                                         all.check_and_set_qps+all.check_and_mutate_qps;


+号两边没有空格，这是没用clang-format？

qinzuoyan · 2018-08-08T02:55:25Z

src/server/pegasus_write_service_impl.h

@@ -544,7 +657,7 @@ class pegasus_write_service::impl : public dsn::replication::replica_base

    // for setting update_response.error after committed.
    std::vector<dsn::apps::update_response *> _update_responses;
-};
+}; // namespace server


这个注释有问题吧？

shengofsun · 2018-08-08T06:25:21Z

补充一些ut吧。

qinzuoyan

还有这几个问题：

thrift自动生成的代码，格式还是与原来保持一致吧，不然会发现diff太多了；
check_and_set和check_and_mutate实现合并公共代码后，逻辑变成很奇怪。还是不要合并了，分开写吧，代码重复就重复点。

qinzuoyan · 2018-08-13T10:04:35Z

src/include/pegasus/client.h

+            mu.sort_key.assign(sort_key.data(), 0, sort_key.length());
+            // mu.value = NULL; //TODO HW unchecked
+            mu.set_expire_ts_seconds = 0;
+            mu_list.emplace_back(mu);


mu_list.emplace_back(std::move(mu));

qinzuoyan · 2018-08-13T10:04:50Z

src/include/pegasus/client.h

+            mu.sort_key.assign(sort_key.data(), 0, sort_key.length());
+            mu.value.assign(value.data(), 0, value.length());
+            mu.set_expire_ts_seconds = 0;
+            mu_list.emplace_back(mu);


mu_list.emplace_back(std::move(mu));

qinzuoyan · 2018-08-13T10:06:28Z

src/include/pegasus/client.h

+            mu.set_expire_ts_seconds = 0;
+            mu_list.emplace_back(mu);
+        }
+        const std::vector<::dsn::apps::mutate> get_mutations() const


这里是不是避免拷贝比较好：

void swap_out_mutations(std::vector<::dsn::apps::mutate> &mutations) { int current_time = ::pegasus::utils::epoch_now(); for (auto &pair : ttl_list) { mu_list[pair.first].set_expire_ts_seconds += (pair.second + current_time); } mutations.swap(mu_list); }

qinzuoyan · 2018-08-13T10:16:52Z

src/include/pegasus/client.h

+                                 int timeout_milliseconds = 5000,
+                                 internal_info *info = nullptr) = 0;
+    // TODO HW 和java-client
+    /// Mutations保持一致，shell如何使用mutate是第二步。不知道mutations该不该使用apps::的类，先这么写，如果需要分离再搞一个类就好了


不要用中文注释。另外这个注释我也没太看明白。

qinzuoyan · 2018-08-14T02:51:38Z

src/client_lib/pegasus_client_impl.cpp

@@ -1015,6 +1015,10 @@ void pegasus_client_impl::async_check_and_mutate(const std::string &hash_key,
    req.check_type = (dsn::apps::cas_check_type::type)check_type;
    req.check_operand.assign(check_operand.c_str(), 0, check_operand.size());
    req.mutate_list = mutations.get_mutations();
+
+    for(auto &mu: req.mutate_list){


这里为什么要打debug日志？

qinzuoyan · 2018-08-14T06:48:47Z

src/server/pegasus_write_service_impl.h

@@ -527,6 +537,93 @@ class pegasus_write_service::impl : public dsn::replication::replica_base
        return false;
    }

+    // for check_and_mutate


此处增加 private:
将以下函数设为私有。

在private作用域里，346行以下都是

qinzuoyan · 2018-08-14T06:49:58Z

src/server/pegasus_write_service_impl.h

@@ -527,6 +537,93 @@ class pegasus_write_service::impl : public dsn::replication::replica_base
        return false;
    }

+    // for check_and_mutate
+
+    int check_phase(const std::string &func_name,


const char* func_name,

qinzuoyan · 2018-08-14T06:52:17Z

src/server/pegasus_write_service_impl.h

+                    bool &is_arg_invalid)
+    {
+        if (!is_check_type_supported(check_type)) {
+            derror_replica("invalid argument for " + func_name + ": decree = {}, error = {}",


derror_replica("invalid argument for {}: decree = {}, error = check type {} not supported", func_name, secree, check_type);

qinzuoyan · 2018-08-14T07:12:37Z

src/client_lib/pegasus_client_impl.cpp

+    auto mutate_list = mutations.get_mutations();
+    for (auto &mu : mutate_list) {
+        req.mutate_list.push_back(mu);
+        ddebug("mu %d %s %s %d",


对于线上不希望打印的日志，用dinfo。因为info是最低的级别，debug线上会打印。

travis测试不过才加的临时打印，是打算去掉的

qinzuoyan · 2018-08-14T07:22:03Z

src/shell/commands.h

@@ -3417,6 +3589,7 @@ inline bool app_stat(command_executor *e, shell_context *sc, arguments args)
        sum.multi_remove_qps += row.multi_remove_qps;
        sum.incr_qps += row.incr_qps;
        sum.check_and_set_qps += row.check_and_set_qps;
+        sum.check_and_mutate_qps += row.check_and_mutate_qps;


上面3575行CAS后面增加： << std::setw(w) << std::right << "CAM"

vagetablechicken · 2018-08-14T14:24:16Z

check_and_set和check_and_mutate实现合并公共代码确实勉强，中间函数参数太多。原来的逻辑，有两处我想修改下。
一是

        if (s.ok()) {	    
        } else if (!s.IsNotFound()) {	
        }
        dassert(s.ok() || s.IsNotFound(), "status = %s", s.ToString().c_str());

修改见check_phase()。

二是

       if (update.return_check_value) {
            resp.check_value_returned = true;
            if (s.ok()) {
                resp.check_value_exist = true;
                resp.check_value = std::move(check_value);
            }
        }

我觉得可以在check完成后紧跟着做这一步，这样即使set或mutate失败，也能返回正确的check结果。不知是否可以？

qinzuoyan · 2018-08-15T09:14:11Z

src/shell/main.cpp

+        "[bytes_less|bytes_less_or_equal|bytes_equal|bytes_greater_or_equal|bytes_greater] "
+        "[int_less|int_less_or_equal|int_equal|int_greater_or_equal|int_greater] "
+        "[-o|--check_operand str] "
+        "[-m|--mutations] "


这里难道不是必须要设置mutations吗？那么-m选项存在的意义是什么？

qinzuoyan · 2018-08-15T09:22:07Z

src/shell/commands.h

@@ -1454,6 +1454,175 @@ inline bool check_and_set(command_executor *e, shell_context *sc, arguments args
    return true;
 }

+inline void load_mutations(pegasus::pegasus_client::mutations &mutations)
+{


load mutations时，没有考虑这些情况：

如何输入不可见字符：其他地方是调用unescape_str()函数

如何处理双引号： set "a b" "c d"

qinzuoyan · 2018-08-15T09:23:22Z

src/shell/commands.h

+        if (op == "set") {
+            fprintf(stderr,
+                    "LOAD: set sortkey %s, value %s, ttl %d\n",
+                    sort_key.c_str(),


pegasus::utils::c_escape_string(sort_key, sc->escape_all).c_str()

qinzuoyan

顺便再更新下rdsn

qinzuoyan · 2018-08-16T08:59:37Z

src/shell/commands.h

            fprintf(stderr,
                    "LOAD: set sortkey %s, value %s, ttl %d\n",
-                    sort_key.c_str(),
-                    value.c_str(),
+                    pegasus::utils::c_escape_string(unescape_str(args[1]), sc->escape_all).c_str(),


"LOAD: set sortkey "%s", value "%s", ttl %d\n"

qinzuoyan · 2018-08-16T09:01:03Z

src/shell/commands.h

+        case 1:
+            mutations.del(unescape_str(args[1]));
+            fprintf(stderr,
+                    "LOAD: del sortkey %s\n",


"LOAD: del sortkey "%s"\n"

qinzuoyan · 2018-08-16T09:02:51Z

src/server/pegasus_write_service_impl.h

@@ -399,12 +413,6 @@ class pegasus_write_service::impl : public dsn::replication::replica_base
                        decree, key, m.value, static_cast<uint32_t>(m.set_expire_ts_seconds));
                } else if (m.operation == ::dsn::apps::mutate_operation::MO_DELETE) {


这里只有两种情况，所以：

if (m.operation == ::dsn::apps::mutate_operation::MO_PUT) { } else { dassert(m.operation == ::dsn::apps::mutate_operation::MO_DELETE, "m.operation = %d", m.operation); .... }

qinzuoyan · 2018-08-16T09:07:06Z

src/server/pegasus_write_service_impl.h

+                           "mutations have invalid operations");
+            // we should write empty record to update rocksdb's last flushed decree
+            return empty_put(decree);
+        }


这么写更好点？在日志中打印更详细的信息

for (int i = 0; i < update.mutate_list.size(); ++i) { auto& mu = update.mutate_list[i]; if (mu.operation != ::dsn::apps::mutate_operation::MO_PUT && mu.operation != ::dsn::apps::mutate_operation::MO_DELETE) { derror_replica("invalid argument for check_and_mutate: decree = {}, error = mutation[{}] uses invalid operation {}", decree, i, mu.operation); resp.error = rocksdb::Status::kInvalidArgument; // we should write empty record to update rocksdb's last flushed decree return empty_put(decree); } }

neverchanje · 2018-08-16T10:01:52Z

src/include/pegasus/client.h

+    struct mutations
+    {
+    private:
+        std::vector<::dsn::apps::mutate> mu_list;


private 为什么不用前缀下划线？_mu_list

qinzuoyan · 2018-08-16T10:08:51Z

我用shell测试check_and_mutate，感觉结果乱掉了：

>>> use temp
>>> set a b c
OK

app_id          : 1
partition_index : 4
decree          : 1
server          : 10.231.58.229:34801
>>> set a c d
OK

app_id          : 1
partition_index : 4
decree          : 2
server          : 10.231.58.229:34801
>>> check_and_mutate
USAGE: 	check_and_mutate       <hash_key> [-c|--check_sort_key str]
	                       [-t|--check_type not_exist|not_exist_or_empty|exist|not_empty]
	                       [match_anywhere|match_prefix|match_postfix]
	                       [bytes_less|bytes_less_or_equal|bytes_equal|bytes_greater_or_equal|bytes_greater]
	                       [int_less|int_less_or_equal|int_equal|int_greater_or_equal|int_greater]
	                       [-o|--check_operand str] [-r|--return_check_value]
>>> check_and_mutate a -c b -t bytes_equal -o c
Load mutations, like
   set <sort_key> <value> [ttl]
   del <sort_key>
Print "ok" to finish loading
>>> set "x\x00y" z
LOAD: set sortkey "x\x00y", value "z", ttl 0
>>> set 
ERROR: invalid mutation, print "ok" to finish loading
>>> set "x\x00y" z
LOAD: set sortkey "x\x00y", value "z", ttl 0
>>> del "xy"
LOAD: del sortkey "xy"
>>> ok
INFO: load mutations done.

hash_key: "a"
check_sort_key: "b"
check_type: bytes_equal
check_operand: "c"
return_check_value: false

Mutate succeed.

app_id          : 1
partition_index : 4
decree          : 3
server          : 10.231.58.229:34801
>>> multi_get a
"a" : "PN\xE9" => "z"
"a" : "b" => "c"
"a" : "c" => "d"
"a" : "ok\x00" => "z"

4 key-value pairs got, fetch completed.

app_id          : 1
partition_index : 4
server          : 10.231.58.229:34801
>>>

qinzuoyan · 2018-08-16T10:16:00Z

src/shell/commands.h

+        fprintf(stderr,
+                "check_operand: \"%s\"\n",
+                pegasus::utils::c_escape_string(check_operand).c_str());
+    }


在这里把mutations打印出来，譬如：

mutation[0].type: SET mutation[0].sort_key: "x" mutation[0].value: "y" mutation[0].ttl_seconds: 0 mutation[1].type: DEL mutation[1].sort_key: "z"

acelyc111 · 2018-08-16T15:07:43Z

src/client_lib/pegasus_client_impl.cpp

+    if (mutations.is_empty()) {
+        derror("invalid mutations: mutations should not be empty.");
+        if (callback != nullptr)
+            callback(PERR_INVALID_HASH_KEY, check_and_mutate_results(), internal_info());


不是PERR_INVALID_HASH_KEY

应当是PERR_INVALID_ARGUMENT

acelyc111 · 2018-08-16T15:16:36Z

src/client_lib/pegasus_client_impl.cpp

+    req.check_sort_key.assign(check_sort_key.c_str(), 0, check_sort_key.size());
+    req.check_type = (dsn::apps::cas_check_type::type)check_type;
+    req.check_operand.assign(check_operand.c_str(), 0, check_operand.size());
+    mutations.get_mutations(req.mutate_list);


get_mutations名字是不是不大合适？

我觉得还可以，java中也是这么写的。毕竟也是const函数，不修改原值。

get_mutations这里考虑到的两点是
1.get时才计算set_expire_ts_seconds
2.用户可能会重复使用同一个mutations对象（例如重试check_and_mutate等场景）
所以选择不修改原值，每次get都会拷贝。
如果不必要这么做，加一个move方法，直接移动？

我觉得现在这样就可以

acelyc111 · 2018-08-16T15:38:26Z

src/server/pegasus_write_service_impl.h

+            auto &mu = update.mutate_list[i];
+            if (mu.operation != ::dsn::apps::mutate_operation::MO_PUT &&
+                mu.operation != ::dsn::apps::mutate_operation::MO_DELETE) {
+                derror_replica("invalid argument for check_and_mutate: decree = {}, error = "


这里的format确认是可以这么写的吧?

应当没问题

acelyc111 · 2018-08-16T15:48:17Z

src/shell/main.cpp

+        "check_and_mutate",
+        "atomically check and mutate",
+        "<hash_key> "
+        "[-c|--check_sort_key str] "


必填参数用<xxx>

这里主要是比较特殊，因为check_type的候选项太多了，一行放不下。所以我上面在check_and_set就按照这种写法来写了。所以这里这么写我觉得也可以的。

acelyc111 · 2018-08-16T15:51:51Z

src/server/pegasus_write_service_impl.h

+            resp.error = check_status.code();
+            return resp.error;
+        }
+        dassert(check_status.ok() || check_status.IsNotFound(),


新加的代码统一都用dassert_xxx的函数吧

qinzuoyan · 2018-08-17T03:22:45Z

src/shell/commands.h

+                stderr,
+                "  mutation[%d].value: \"%s\"\n",
+                i,
+                pegasus::utils::c_escape_string(copy_of_mutations[i].value.to_string()).c_str());


没有打印ttl_seconds

ttl这个时候算的值和传入pegasus_client之后再get的值不一样，感觉会造成误解，所以我没有打印

没关系，因为每次get出来的值都不一样。我们这里打印出来，只是告诉用户传的参数是什么。

qinzuoyan · 2018-08-17T03:23:55Z

src/shell/commands.h

+        case 0:
+            ttl = 0;
+            if (arg_count == 4) {
+                ttl = std::stoi(args[3]);


这里不能用std::stoi，因为如果输入非法参数，会抛异常，然后shell就core掉。你可以输入set a b c试试。
建议改为：

if (arg_count == 4) { - ttl = std::stoi(args[3]); + if (!dsn::buf2int32(args[3], ttl)) { + fprintf(stderr, + "ERROR: parse \"%s\" as ttl failed, " + "print \"ok\" to finish loading\n", + args[3]); + break; + } + if (ttl <= 0) { + fprintf(stderr, + "ERROR: invalid ttl %s, " + "print \"ok\" to finish loading\n", + args[3]); + break; + } }

ttl设为0，不应该算作invalid。我打算改为

ttl = 0; if (arg_count == 4) { char *end_ptr = nullptr; long l_ttl = strtol(args[3], &end_ptr, 10); if (end_ptr == args[3]) { fprintf(stderr, "ERROR: parse \"%s\" as ttl failed, " "print \"ok\" to finish loading\n", args[3]); break; } if (l_ttl > INT_MAX || l_ttl < 0) { fprintf(stderr, "ERROR: invalid ttl %s, " "print \"ok\" to finish loading\n", args[3]); break; } ttl = l_ttl; }

这样设计有一个情况是
"111c"这样的，会截掉数字后不合法的字符，ttl会等于111，是否可行？

不可行。"111c"就不应当处理为111，而是视为非法。
这里就不要自己写了，直接用封装好的函数buf2int32吧，自己写容易考虑不全。你看上面的set_value()函数，里面也有处理ttl的地方。
为了保持和set_value()的一致，用户也不允许传0；如果不设置ttl，那就不传。

neverchanje · 2018-08-17T03:31:06Z

src/client_lib/pegasus_client_impl.cpp

+        derror("invalid hash key: hash key length should be less than UINT16_MAX, but %d",
+               (int)hash_key.size());
+        if (callback != nullptr)
+            callback(PERR_INVALID_HASH_KEY, check_and_mutate_results(), internal_info());


那这里也要改了，建议给这个改动加个单测

这里为什么要改？

qinzuoyan · 2018-08-17T06:26:13Z

src/shell/commands.h

+                if (end_ptr == args[3]) {
+                    fprintf(stderr,
+                            "ERROR: parse \"%s\" as ttl failed, "
+                            "print \"ok\" to finish loading\n",


print "ok" to finish loading, print "abort" to abort this command\n

qinzuoyan · 2018-08-17T06:26:18Z

src/shell/commands.h

+                if (l_ttl > INT_MAX || l_ttl < 0) {
+                    fprintf(stderr,
+                            "ERROR: invalid ttl %s, "
+                            "print \"ok\" to finish loading\n",


print "ok" to finish loading, print "abort" to abort this command\n

qinzuoyan · 2018-08-17T06:30:31Z

src/shell/commands.h

+        case 0:
+            ttl = 0;
+            if (arg_count == 4) {
+                ttl = std::stoi(args[3]);


不可行。"111c"就不应当处理为111，而是视为非法。
这里就不要自己写了，直接用封装好的函数buf2int32吧，自己写容易考虑不全。你看上面的set_value()函数，里面也有处理ttl的地方。
为了保持和set_value()的一致，用户也不允许传0；如果不设置ttl，那就不传。

server: add check_and_mutate() interface and implementation (apache#161)

Former-commit-id: bd5573b269ebe3f88e1409b5871b83dcc1e1e6de [formerly 6476639] Former-commit-id: 05a2d0d6d9576352686585153a35a8ca550dea17

…e to 30s (apache#161)

huangwei5 added 2 commits August 6, 2018 17:19

server: check_and_mutate interface

64685b4

server: check_and_mutate interface

02e8965

vagetablechicken requested review from qinzuoyan and shengofsun August 6, 2018 09:48

qinzuoyan reviewed Aug 6, 2018

View reviewed changes

shengofsun reviewed Aug 6, 2018

View reviewed changes

HuangWei added 3 commits August 7, 2018 10:40

Merge branch 'master' into master

6f55951

check_and_mutate: fix based on review

02e1b92

check_and_mutate: entire implementation

8081041

vagetablechicken changed the title ~~server: check_and_mutate interface~~ server: check_and_mutate() Aug 7, 2018

qinzuoyan reviewed Aug 8, 2018

View reviewed changes

huangwei5 added 11 commits August 9, 2018 15:15

check_and_mutate(): fix based on review

7f62ae9

check_and_mutate():

ebf111b

Merge branch 'master' into master

b8e66c7

Merge branch 'master' of github.com:vagetablechicken/pegasus

0b6594b

:check_and_mutate test & client & shell, fix check_and_set bug

d62f9ba

debug for travis

2c9bc76

debug

eb30735

debug

b924587

debug

110555e

vector hard copy

9507cd7

change hard copy to push_back()

aee1daa

qinzuoyan reviewed Aug 14, 2018

View reviewed changes

HuangWei added 5 commits August 14, 2018 17:03

Merge branch 'master' into master

5fc6ea6

fix

0f83bec

conflict fix

7e2a266

fix bug & clang-format

14c7171

fix bugs & deploy clang-format

2a4e4c3

qinzuoyan reviewed Aug 15, 2018

View reviewed changes

huangwei5 added 3 commits August 16, 2018 16:07

fix argument check and shell load_mutations

544760f

fix load_mutations

21b978a

fix auto

91d6d91

qinzuoyan reviewed Aug 16, 2018

View reviewed changes

fix based on review

a7e5ae0

qinzuoyan previously approved these changes Aug 16, 2018

View reviewed changes

qinzuoyan requested a review from acelyc111 August 16, 2018 09:56

neverchanje reviewed Aug 16, 2018

View reviewed changes

qinzuoyan closed this Aug 16, 2018

qinzuoyan reopened this Aug 16, 2018

qinzuoyan reviewed Aug 16, 2018

View reviewed changes

acelyc111 reviewed Aug 16, 2018

View reviewed changes

fix based on review

9362f1f

vagetablechicken dismissed qinzuoyan’s stale review via 9362f1f August 17, 2018 02:12

qinzuoyan reviewed Aug 17, 2018

View reviewed changes

neverchanje reviewed Aug 17, 2018

View reviewed changes

fix shell

90bc568

qinzuoyan reviewed Aug 17, 2018

View reviewed changes

fix mutation ttl

0fb9684

qinzuoyan approved these changes Aug 17, 2018

View reviewed changes

shengofsun approved these changes Aug 17, 2018

View reviewed changes

acelyc111 approved these changes Aug 17, 2018

View reviewed changes

qinzuoyan merged commit 6476639 into apache:master Aug 17, 2018

vagetablechicken pushed a commit to vagetablechicken/pegasus that referenced this pull request Aug 17, 2018

Merge pull request #1 from XiaoMi/master

5032874

server: add check_and_mutate() interface and implementation (apache#161)

neverchanje added the component/api pegasus client interfaces label Sep 13, 2018

cauchy1988 pushed a commit to cauchy1988/incubator-pegasus that referenced this pull request May 7, 2022

feat: support session reset time windows config and init default valu…

4222817

…e to 30s (apache#161)

acelyc111 pushed a commit that referenced this pull request Jun 23, 2022

serialization: completely remove protobuf support (#161)

4d47b8d

		@@ -399,12 +413,6 @@ class pegasus_write_service::impl : public dsn::replication::replica_base
		decree, key, m.value, static_cast<uint32_t>(m.set_expire_ts_seconds));
		} else if (m.operation == ::dsn::apps::mutate_operation::MO_DELETE) {

server: add check_and_mutate() interface and implementation #161

server: add check_and_mutate() interface and implementation #161

Conversation

vagetablechicken commented Aug 6, 2018 • edited by qinzuoyan Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qinzuoyan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shengofsun commented Aug 8, 2018

qinzuoyan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vagetablechicken commented Aug 14, 2018 • edited by qinzuoyan Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qinzuoyan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qinzuoyan commented Aug 16, 2018

qinzuoyan Aug 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qinzuoyan Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

qinzuoyan Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vagetablechicken commented Aug 6, 2018 •

edited by qinzuoyan

Loading

vagetablechicken commented Aug 14, 2018 •

edited by qinzuoyan

Loading

qinzuoyan Aug 16, 2018 •

edited

Loading

qinzuoyan Aug 17, 2018 •

edited

Loading

qinzuoyan Aug 17, 2018 •

edited

Loading