feat(java-client): add maven-thrift-plugin #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalk
changed the title
shalk
force-pushed
the
add-thrift-plugin
branch
from
ad4711f
to
0e121c9
Compare
shalk
changed the title
acelyc111
reviewed
May 30, 2024
| @@ -48,21 +48,4 @@ if ! $thrift -version | grep "0.11.0" ; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| TMP_DIR=./gen-java | |||
There was a problem hiding this comment.
It seems thrift will not be used any where in java-client, can we remove this file entirely?
There was a problem hiding this comment.
thrift will be used when mvn compile or mvn test. If i remove the file , if i remove the file https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/test_python-client.yml#L68 will be add in to github action
There was a problem hiding this comment.
OK, let's keep it in current step. We can do that in next patches.
acelyc111
approved these changes
Jun 27, 2024
| @@ -48,21 +48,4 @@ if ! $thrift -version | grep "0.11.0" ; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| TMP_DIR=./gen-java | |||
There was a problem hiding this comment.
OK, let's keep it in current step. We can do that in next patches.
empiredan
approved these changes
Jun 27, 2024
ruojieranyishen
pushed a commit
to ruojieranyishen/incubator-pegasus
that referenced
this pull request
Jul 17, 2024
… instead of script (apache#1997) apache#1664 Add thrift-maven-plugin by referencing following links: - https://issues.apache.org/jira/browse/THRIFT-1536 - apache/parquet-java#600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #1664
ref: https://issues.apache.org/jira/browse/THRIFT-1536
ref: apache/parquet-java#600
What is changed and how does it work?
Checklist
Tests
Code changes
Side effects
Related changes