bugfix: use std::abs explicit to avoid reference to cstdlib abs, which will c… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
previously approved these changes
Dec 18, 2018
neverchanje
previously approved these changes
Dec 18, 2018
acelyc111
dismissed stale reviews from neverchanje and qinzuoyan
via
f3761fb
…onvert double to int
acelyc111
force-pushed
the
fix_command
branch
from
81a0758
to
979a022
Compare
qinzuoyan
approved these changes
Dec 20, 2018
neverchanje
approved these changes
Dec 20, 2018
qinzuoyan
pushed a commit
that referenced
this pull request
Feb 27, 2019
…onvert double to int (#234)
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
…onvert double to int (apache#234) Former-commit-id: 9390f68d56fc6274920da89cccc97b5277444421 [formerly ab56419] Former-commit-id: b8de97673ef06b431ed466220b3498381da7a075
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use std::abs explicit to avoid reference to cstdlib abs, which will convert double to int