shell: improve copy_data/clear_data/count_data to support HashKey/SortKey/Value filters #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
requested review from
neverchanje,
acelyc111,
hycdong and
mentoswang
|
感觉这几个命令很多代码都是重复的，应该要抽出来做成公共函数，可以提个 issue 做这个事情 |
我已经抽过一次了，你看看 |
acelyc111
reviewed
Feb 27, 2019
| } | ||
| std::vector<pegasus::pegasus_client::pegasus_scanner *> tmp_scanners; | ||
| tmp_scanners.push_back(scanners[partition]); | ||
| tmp_scanners.swap(scanners); |
neverchanje
previously approved these changes
Feb 27, 2019
acelyc111
approved these changes
Feb 27, 2019
neverchanje
approved these changes
Feb 27, 2019
mentoswang
approved these changes
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
…tKey/Value filters (apache#292) Former-commit-id: 025e991da23d58c849ba79fc5688031dadfb75c0 [formerly d1c6601] Former-commit-id: 3e7e460c459a479a44cda9e90825de5ad6a52254
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.