-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Update installation.md & add an exit code in start_zk #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
previously approved these changes
May 9, 2019
acelyc111
reviewed
May 9, 2019
build dependencies在ubuntu18.04和centos7上均做了验证。附带修复了一下start_zk的逻辑,start_zk失败后不会start servers。 |
vagetablechicken
requested review from
acelyc111 and
qinzuoyan
and removed request for
acelyc111
May 10, 2019 10:09
vagetablechicken
changed the title
Update installation.md
*: Update installation.md & add an exit code in start_zk
May 10, 2019
vagetablechicken
requested review from
neverchanje,
hycdong,
mentoswang,
foreverneverer and
zhangyifan27
May 16, 2019 06:50
neverchanje
approved these changes
May 16, 2019
hycdong
approved these changes
May 16, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 14, 2019
* dependencies fix * exit 1 if start_zk failed
neverchanje
pushed a commit
that referenced
this pull request
Jun 21, 2019
* dependencies fix * exit 1 if start_zk failed
neverchanje
pushed a commit
that referenced
this pull request
Jul 1, 2019
* dependencies fix * exit 1 if start_zk failed
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
* dependencies fix * exit 1 if start_zk failed Former-commit-id: d6e150dc9f0efe57c385639ee8e349ff1db86e82 [formerly 3659ea7] Former-commit-id: 448daeaa672884e9ea0cab2bb7e5b967d4035843
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.