feat(collector): add statistics for estimate key number of partition #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
requested review from
acelyc111,
levy5307,
zhangyifan27 and
neverchanje
levy5307
reviewed
Dec 3, 2019
levy5307
reviewed
Dec 3, 2019
acelyc111
reviewed
Dec 3, 2019
acelyc111
reviewed
Dec 3, 2019
neverchanje
reviewed
Dec 3, 2019
levy5307
reviewed
Dec 3, 2019
levy5307
reviewed
Dec 3, 2019
neverchanje
reviewed
Dec 3, 2019
neverchanje
reviewed
Dec 3, 2019
acelyc111
approved these changes
Dec 3, 2019
neverchanje
approved these changes
Dec 3, 2019
neverchanje
added
the
type/perf-counter
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some case needs get the count of table data, this pr provides the statistic for collector and named
rdb.estimate_num_keysWhat is changed and how it works?
In
update_replica_rocksdb_statistics()ofpegasus_server_impl.cpp, the pr add_db->GetProperty(rocksdb::DB::Properties::kEstimateNumKeys, &str_val), when the sever start, the statistic will be update periodicallyCheck List
Related changes
yes
no
yes
yes
Other
If some key is duplicate, the value of key number will be count multi time, so only after compaction, the value just be relatively accurate.
New perf-counter: