Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hotspot): calculator auto detect hotkey in the hot partition #604

Merged
merged 14 commits into from
Sep 22, 2020
Merged

feat(hotspot): calculator auto detect hotkey in the hot partition #604

merged 14 commits into from
Sep 22, 2020

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Sep 18, 2020 •
edited by neverchanje
Loading

What problem does this PR solve?

Add a policy for hotspot_partition_calculator to send RPC to start hotkey detect in the replica_server auto.

What is changed and how it works?

we can set enable_hotkey_auto_detect = true to start auto detect hotkey, and set hot_partition_threshold and occurrence_threshold to adjust sensitivity.

Config changes

[pegasus.collector]
+ enable_hotkey_auto_detect = false
+ hot_partition_threshold = 3
+ occurrence_threshold = 100

@Smityz Smityz changed the title update feat(hotspot): calculator auto detect hotkey in the hot partition Sep 18, 2020
@levy5307 levy5307 added the type/config-change Added or modified configuration that should be noted on release note of new version. label Sep 18, 2020
acelyc111
acelyc111 reviewed Sep 18, 2020
View reviewed changes
src/server/hotspot_partition_calculator.cpp Outdated Show resolved Hide resolved
src/server/hotspot_partition_calculator.cpp Outdated Show resolved Hide resolved
src/server/hotspot_partition_calculator.cpp Outdated Show resolved Hide resolved
src/server/hotspot_partition_calculator.cpp Outdated Show resolved Hide resolved
src/server/test/config.ini Outdated Show resolved Hide resolved
acelyc111
acelyc111 previously approved these changes Sep 21, 2020
View reviewed changes
@acelyc111 acelyc111 merged commit a1f158b into apache:master Sep 22, 2020
@Smityz Smityz deleted the hotspot-pool branch October 20, 2020 09:24
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@levy5307
feat(security): implement sasl_wrapper which is a wrapper to operate …
3105434 
…sasl (#604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 left review comments

@hycdong hycdong hycdong approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smityz @acelyc111 @hycdong @levy5307