refactor: use rocksdb_wrapper::get to reimplement incr #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
neverchanje
previously approved these changes
Dec 3, 2020
acelyc111
reviewed
Dec 6, 2020
src/server/rocksdb_wrapper.h
Outdated
| struct db_get_context; | ||
| class pegasus_server_impl; | ||
|
|
||
| static constexpr int FAIL_DB_GET = -104; |
There was a problem hiding this comment.
Could you define it in cpp?
And what does '-104' mean?
There was a problem hiding this comment.
It it internal error codes used for fail injection, and there are three other error codes defined in pegasus_write_service_impl.h:
static constexpr int FAIL_DB_WRITE_BATCH_PUT = -101;
static constexpr int FAIL_DB_WRITE_BATCH_DELETE = -102;
static constexpr int FAIL_DB_WRITE = -103;
I think 104 has no special meaning. And I don't want to change it, because it is not the main purpose for this pull reqeust.
acelyc111
previously approved these changes
Dec 7, 2020
neverchanje
approved these changes
Dec 8, 2020
acelyc111
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
rocksdb_wrapperto wrap the operation of rocksdb, and putdb_getinto it.rocksdb_wrapper::getto reimplement incr function.Check List
Tests