Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use rocksdb_wrapper to reimplement empty_put #670

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Jan 6, 2021

What problem does this PR solve?

use rocksdb_wrapper to reimplement empty_put

Check List

Tests

  • Unit test
    There are some unit tests in pegasus_write_service_test.cpp to test empty_put

  • Manual test (add detailed scripts or steps below)
    Use incr to trigger empty_put

>>> use temp
OK
>>> set a b c
OK

app_id          : 2
partition_index : 4
decree          : 1
server          : 10.232.55.210:34802
>>> incr a b 1
ERROR: invalid argument

app_id          : 2
partition_index : 4
decree          : 2
server          : 10.232.55.210:34802
>>> incr a b 1
ERROR: invalid argument

app_id          : 2
partition_index : 4
decree          : 3
server          : 10.232.55.210:34802
>>> incr a b 5
ERROR: invalid argument

app_id          : 2
partition_index : 4
decree          : 5
server          : 10.232.55.210:34802

@levy5307 levy5307 merged commit bd10cd0 into apache:master Jan 7, 2021
@levy5307 levy5307 deleted the empty-put branch January 7, 2021 02:33
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants