Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compilation error in pegasus_utils #675

Merged
merged 5 commits into from
Jan 18, 2021
Merged

fix: compilation error in pegasus_utils #675

merged 5 commits into from
Jan 18, 2021

Conversation

neverchanje
Copy link
Contributor

What problem does this PR solve? 

/home/wutao1/git/pegasus/src/base/test/../pegasus_utils.h:65:32: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
   65 |         return std::move(result);
      |                                ^
/home/wutao1/git/pegasus/src/base/test/../pegasus_utils.h:65:32: note: remove ‘std::move’ call

What is changed and how it works?

@neverchanje neverchanje merged commit c9f442d into apache:master Jan 18, 2021
@neverchanje neverchanje deleted the fix branch January 18, 2021 15:41
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@hycdong
feat(split): secondary start split (#675)
65edf61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverchanje @acelyc111 @levy5307