fix: pack without libaio #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
previously approved these changes
Jan 8, 2021
levy5307
previously approved these changes
Jan 11, 2021
hycdong
reviewed
Jan 21, 2021
hycdong
previously approved these changes
Jan 26, 2021
levy5307
previously approved these changes
Feb 2, 2021
scripts/pack_server.sh
Outdated
| exit 1 | ||
| fi | ||
| SYS_LIB_NAME=$(get_system_libname server "$1") | ||
| copy_file "${SYS_LIB_PATH}" "${pack}/bin/${SYS_LIB_NAME}" |
There was a problem hiding this comment.
why not copy_file "${SYS_LIB_PATH}" "${pack}/bin"?
There was a problem hiding this comment.
I'm not 100% sure but ${SYS_LIB_NAME} and ${SYS_LIB_PATH} could point to different file names.
scripts/pack_tools.sh
Outdated
| copy_file `get_system_lib shell zstd` ${pack}/DSN_ROOT/lib/`get_system_libname shell zstd` | ||
| copy_file `get_system_lib shell lz4` ${pack}/DSN_ROOT/lib/`get_system_libname shell lz4` | ||
|
|
||
| pack_system_lib() { |
There was a problem hiding this comment.
It's better to move pack_system_lib() to pack_common.sh .
hycdong
reviewed
Feb 24, 2021
hycdong
approved these changes
Feb 24, 2021
levy5307
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Because we removed the dependency of libaio in the latest version, the binary is not linked with libaio anymore.
It causes pegasus unable to package while running
./run.sh pack_server.What is changed and how it works?
I refactored the packaging script and let it pack without libaio.
Check List
Tests
Good pass
Good pass