refactor: add some base classes to refactor pegasus_value_schema #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Apr 13, 2021
Smityz
reviewed
Apr 15, 2021
neverchanje
reviewed
Apr 15, 2021
neverchanje
reviewed
Apr 15, 2021
neverchanje
reviewed
Apr 15, 2021
neverchanje
approved these changes
Apr 16, 2021
foreverneverer
approved these changes
Apr 19, 2021
zhangyifan27
pushed a commit
to zhangyifan27/pegasus
that referenced
this pull request
Jun 1, 2021
Closed
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add some base classes to refactor pegasus_value_schema, for example:
pegasus_value_schema,pegasus_value_segmentandpegasus_value_manager.The global design is here:
Check List
Tests
No code actually. I will add unit tests in later pull requests.