Geo: geo library support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
acelyc111
commented
Jun 9, 2018
•
acelyc111
commented
- add geo library, support set/del/search_radial/distance APIs
- integrate the library into redis proxy
acelyc111
requested review from
qinzuoyan,
shengofsun,
neverchanje,
LoveHeat,
hycdong and
vagetablechicken
Closed
shengofsun
reviewed
Jun 11, 2018
src/geo/sample/sample.cpp
Outdated
| // ./pegasus_geo_test onebox temp temp_geo | ||
| int main(int argc, char **argv) | ||
| { | ||
| if (argc != 4) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
shengofsun
reviewed
Jun 11, 2018
src/geo/sample/sample.cpp
Outdated
| auto extractor = [](const std::string &value, S2LatLng &latlng) { | ||
| std::vector<std::string> data; | ||
| dsn::utils::split_args(value.c_str(), data, '|'); | ||
| if (data.size() <= 6) { |
shengofsun
reviewed
Jul 9, 2018
| return ret; | ||
| } | ||
|
|
||
| void geo_client::async_del(const std::string &hash_key, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/geo/lib/geo_client.cpp
Outdated
| int timeout_milliseconds, | ||
| int ttl_seconds) | ||
| { | ||
| async_del( |
There was a problem hiding this comment.
另外在set的时候有没有必要check下现在的经纬度是不是和之前的一样？一样是不是可以做一些优化？
There was a problem hiding this comment.
这个没有必要，一是我们不对业务数据做假设，二是没必要增加逻辑复杂度
There was a problem hiding this comment.
也还好吧，反正set前会有一轮get的。感觉不会增加多大复杂度。而且业务是那种没事灌一批的话去，其实这么做也是挺值得的。
可以先留个TODO
src/geo/lib/geo_client.cpp
Outdated
| scan_one_area_callback &&callback, | ||
| std::vector<SearchResult> &result) | ||
| { | ||
| dsn::tasking::enqueue(LPC_GEO_SCAN_DATA, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| // generate hash key | ||
| S2CellId leaf_cell_id = S2Cell(latlng).id(); | ||
| S2CellId parent_cell_id = leaf_cell_id.parent(_min_level); | ||
| geo_hash_key = parent_cell_id.ToString(); // [0,5]{1}/[0,3]{_min_level} |
src/geo/lib/geo_client.cpp
Outdated
| } | ||
|
|
||
| // scan all cell ids | ||
| std::shared_ptr<std::list<std::vector<SearchResult>>> results( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/geo/lib/geo_client.cpp
Outdated
| } | ||
| }; | ||
|
|
||
| std::shared_ptr<dsn::task_tracker> tracker(new dsn::task_tracker); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
shengofsun
previously approved these changes
Jul 11, 2018
qinzuoyan
reviewed
Jul 11, 2018
src/shell/commands.h
Outdated
| @@ -1708,19 +1708,22 @@ inline bool copy_data(command_executor *e, shell_context *sc, arguments args) | |||
| {"max_split_count", required_argument, 0, 's'}, | |||
| {"max_batch_count", required_argument, 0, 'b'}, | |||
| {"timeout_ms", required_argument, 0, 't'}, | |||
| {"geo_data", optional_argument, 0, 'g'}, | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/shell/commands.h
Outdated
|
|
||
| optind = 0; | ||
| while (true) { | ||
| int option_index = 0; | ||
| int c; | ||
| c = getopt_long(args.argc, args.argv, "c:a:s:b:t:", long_options, &option_index); | ||
| c = getopt_long(args.argc, args.argv, "c:a:s:b:t:g:", long_options, &option_index); |
qinzuoyan
approved these changes
Jul 11, 2018
shengofsun
approved these changes
Jul 11, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
* add geo library, support set/del/search_radial/distance APIs * integrate the library into redis proxy Former-commit-id: cb41fabdc0711354c7760c0882598ed981a31374 [formerly 24fec41] Former-commit-id: d97b5f76ee0dc10974d0edcbf57a0d35c9a3e3b3
cauchy1988
pushed a commit
to cauchy1988/incubator-pegasus
that referenced
this pull request
May 7, 2022
acelyc111
referenced
this pull request
in acelyc111/pegasus
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.