-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch exception if unmarshall the rpc request encounters error #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smityz
reviewed
Jul 26, 2021
hycdong
reviewed
Jul 27, 2021
hycdong
added
the
type/perf-counter
PR that made modification on perf-counter, which should be noted in release note.
label
Jul 27, 2021
hycdong
approved these changes
Jul 28, 2021
foreverneverer
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/perf-counter
PR that made modification on perf-counter, which should be noted in release note.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In previous implementation, the cluster will crash if we receive a dirty muation log, and will not recover unless the dirty logs are clear. For more details: #617
So in pr(XiaoMi/rdsn#863), I changed the way from coredump to throw exception, and we can catch the exception to avoid cluster crash.
Checklist
Tests
[replica*app.pegasus*recent_corrupt_write_count@2.4, VOLATILE_NUMBER, 1.00]
pegasus_server_write.cpp:106:on_batched_writes(): pegasus batch writes handler failed, from ={ip}:{port}, exception =no more data to read after end-of-buffer