-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: coredump when table name contains '_' and prometheus is enabled #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
fix coredump when table name contains '_' and prometheus is enabled
fix: coredump when table name contains '_' and prometheus is enabled
Oct 18, 2021
levy5307
previously approved these changes
Oct 19, 2021
acelyc111
reviewed
Oct 19, 2021
acelyc111
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution @padme-jin .
levy5307
approved these changes
Oct 19, 2021
Closed
hycdong
pushed a commit
that referenced
this pull request
Oct 27, 2021
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After we enable prometheus(set "perf_counter_sink" to "prometheus"), pegasus ended up core dumped after restart.
We debuged the core, found out it was cored while analysing table name that contains "_".
This PR fixes the bug by changing the order of formating table names.
What is changed and how does it work?
Prometheus does not support some special charactor in metric name.
This original code first formated the table name by replacing special charactor to "" or "@".
Then, it try to parse gpid as prometheus labels by spliting the foramted name by ":" or "".
Unfortunately, tables that already contains "_" may results in unexpected group result, which eventually ended up core.
Checklist
Tests
Code changes
Side effects
Related changes