Skip to content

Commit

Permalink
optimize: add independent nacos for the CI process. (#6836)
Browse files Browse the repository at this point in the history
  • Loading branch information
yangli-stu authored Sep 10, 2024
1 parent f2577cf commit fde59c1
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 5 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ jobs:
ports:
- 6379:6379
options: --health-cmd="redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3
nacos:
image: nacos/nacos-server:v2.4.2
ports:
- 8848:8848
env:
MODE: standalone
SPRING_SECURITY_ENABLED: false
options: --health-cmd="curl -f http://localhost:8848/nacos" --health-interval=10s --health-timeout=5s --health-retries=3 --health-start-period=30s
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
2 changes: 2 additions & 0 deletions changes/en-us/2.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6808](https://github.com/apache/incubator-seata/pull/6808)] change version to 2.2.0-SNAPSHOT
- [[#6819](https://github.com/apache/incubator-seata/pull/6819)] merge the packaging processes of namingserver and seata-server
- [[#6827](https://github.com/apache/incubator-seata/pull/6827)] rename namingserver registry type
- [[#6836](https://github.com/apache/incubator-seata/pull/6836)] add independent nacos for the CI process


### refactor:
Expand Down Expand Up @@ -137,5 +138,6 @@ Thanks to these contributors for their code commits. Please report an unintended
- [xingfudeshi](https://github.com/xingfudeshi)
- [xiaoxiangyeyu0](https://github.com/xiaoxiangyeyu0)
- [LegGasai](https://github.com/LegGasai)
- [yangli-stu](https://github.com/yangli-stu)

Also, we receive many valuable issues, questions and advices from our community. Thanks for you all.
2 changes: 2 additions & 0 deletions changes/zh-cn/2.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
- [[#6808](https://github.com/apache/incubator-seata/pull/6808)] 修改版本号为2.2.0-SNAPSHOT
- [[#6819](https://github.com/apache/incubator-seata/pull/6819)] namingserver与server的合并打包
- [[#6827](https://github.com/apache/incubator-seata/pull/6827)] 重命名namingserver注册类型改为seata
- [[#6836](https://github.com/apache/incubator-seata/pull/6836)] 为CI流程增加独立nacos


### refactor:
Expand Down Expand Up @@ -138,6 +139,7 @@
- [xingfudeshi](https://github.com/xingfudeshi)
- [xiaoxiangyeyu0](https://github.com/xiaoxiangyeyu0)
- [LegGasai](https://github.com/LegGasai)
- [yangli-stu](https://github.com/yangli-stu)

同时,我们收到了社区反馈的很多有价值的issue和建议,非常感谢大家。

Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

public class NacosMockTest {
private static ConfigService configService;
private static final String NACOS_ENDPOINT = "console.nacos.io:80";
private static final String NACOS_ENDPOINT = "127.0.0.1:8848";

private static final String NACOS_GROUP = "SEATA_GROUP";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ registry {

nacos {
application = "seata-server"
serverAddr = "console.nacos.io:80"
serverAddr = "127.0.0.1:8848"
group = "SEATA_GROUP"
namespace = ""
username = ""
Expand Down Expand Up @@ -77,7 +77,7 @@ config {
type = "nacos"

nacos {
serverAddr = "console.nacos.io:80"
serverAddr = "127.0.0.1:8848"
namespace = ""
group = "SEATA_GROUP"
dataId = "seata-mock"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ config {
dataId = "seata.properties"
}
test {
serverAddr = "console.nacos.io:80"
serverAddr = "127.0.0.1:8848"
namespace = ""
group = "SEATA_GROUP"
dataId = ""
Expand Down
2 changes: 1 addition & 1 deletion config/seata-config-nacos/src/test/resources/registry.conf
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ registry {

nacos {
application = "seata-server"
serverAddr = "console.nacos.io:80"
serverAddr = "127.0.0.1:8848"
group = "SEATA_GROUP"
namespace = ""
username = ""
Expand Down

0 comments on commit fde59c1

Please sign in to comment.