Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQLUndoUpdateExecutor中UPDATE_SQL_TEMPLATE的注释不正确 #5297

Closed
1 task
ZhangShiYeChina opened this issue Feb 3, 2023 · 0 comments · Fixed by #5298
Closed
1 task

MySQLUndoUpdateExecutor中UPDATE_SQL_TEMPLATE的注释不正确 #5297

ZhangShiYeChina opened this issue Feb 3, 2023 · 0 comments · Fixed by #5298
Assignees
@ZhangShiYeChina

Comments

@ZhangShiYeChina
Copy link
Contributor

ZhangShiYeChina commented Feb 3, 2023 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

在1.6.1 版本中MySQLUndoUpdateExecutor#UPDATE_SQL_TEMPLATE这个字段的注释是

UPDATE a SET x = ?, y = ?, z = ? WHERE pk1 in (?) pk2 in (?)

实际sql的格式并非如此

Ⅱ. Describe what happened

构建where条件的源码如下：
image

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

这个注释应该修改为：

 UPDATE a SET x = ?, y = ?, z = ? WHERE pk1 =? and pk2 =?

Ⅴ. Anything else we need to know?

五

Ⅵ. Environment:

  • JDK version :
  • Seata version: 1.6.1
  • OS :
  • Others:
ZhangShiYeChina added a commit to ZhangShiYeChina/seata that referenced this issue Feb 3, 2023
@ZhangShiYeChina
bugfix:
d86f6d2 
1. Correct the comment on MySQLUndoUpdateExecutor#UPDATE_SQL_TEMPLATE (apache#5297)
2. Do not remove GlobalSession when retry rollback or retry commit timeout (apache#5293)
ZhangShiYeChina added a commit to ZhangShiYeChina/seata that referenced this issue Feb 3, 2023
@ZhangShiYeChina
bugfix:
ec205e1 
1. Correct the comment on MySQLUndoUpdateExecutor#UPDATE_SQL_TEMPLATE (apache#5297)
2. Do not remove GlobalSession when retry rollback or retry commit timeout (apache#5293)
This was referenced Feb 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhangShiYeChina ZhangShiYeChina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: don't remove GlobalSession when retry rollback or retry commit timeout ZhangShiYeChina/seata
1 participant
@ZhangShiYeChina