Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: bypass modify the primary key #4953

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4952

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4953 (6893754) into develop (843489d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 6893754 differs from pull request most recent head c7a6774. Consider uploading reports for the commit c7a6774 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4953   +/-   ##
==========================================
  Coverage      48.70%   48.71%           
- Complexity      4078     4079    +1     
==========================================
  Files            736      736           
  Lines          25818    25822    +4     
  Branches        3184     3184           
==========================================
+ Hits           12575    12579    +4     
- Misses         11907    11909    +2     
+ Partials        1336     1334    -2     
Impacted Files Coverage Δ
...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java 31.14% <0.00%> (-0.35%) ⬇️
...a/server/storage/db/lock/LockStoreDataBaseDAO.java 50.73% <0.00%> (-0.51%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Sep 28, 2022
@funky-eyes funky-eyes added this to the 1.6.0 milestone Sep 28, 2022
@slievrly slievrly merged commit d0f324c into apache:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module multilingual type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There InsertOnDuplicateUpdate is an issue with bypassing modifying the primary key
4 participants