Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize tcc fence record not exists errMessage #4981

Merged

Conversation

github-ganyu
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

RecordNotExists should be used when TCC fence records do not exist

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #4981 (74b918b) into develop (f300ca6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4981   +/-   ##
==========================================
  Coverage      48.77%   48.77%           
  Complexity      4078     4078           
==========================================
  Files            734      734           
  Lines          25855    25855           
  Branches        3190     3190           
==========================================
+ Hits           12610    12611    +1     
+ Misses         11902    11901    -1     
  Partials        1343     1343           
Impacted Files Coverage Δ
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java 0.00% <ø> (ø)
.../io/seata/common/exception/FrameworkErrorCode.java 94.44% <100.00%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Oct 9, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 6c1c857 into apache:develop Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants