Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix the problem that protobuf compilation fails(for dev) #5274

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Feb 1, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

引用高版本的 protobuf-maven-plugin 插件时,编译会出现命令行过长导致编译失败(Window x86环境下)
目前添加 useArgumentFile 配置项来兼容,配置项说明:

https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html
If set to true, all command line arguments to protoc will be written to a file, and only a path to that file will be passed to protoc on the command line. This helps prevent Command line is too long errors when the number of .proto files is large.NOTE: This is only supported for protoc 3.5.0 and higher.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

boolean 0.6.0 If set to true, all command line arguments to protoc will be written to a file, and only a path to that file will be passed to protoc on the command line. This helps prevent Command line is too long errors when the number of .proto files is large.
NOTE: This is only supported for protoc 3.5.0 and higher.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 1, 2023
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize:fix the problem that protobuf compilation fails(for dev) optimize: fix the problem that protobuf compilation fails(for dev) Feb 1, 2023
@funky-eyes funky-eyes merged commit 851ed6d into apache:develop Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants