Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: that keywords don't add escaped characters #5307

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Feb 6, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Fixes #5291

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 6, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Feb 6, 2023
@funky-eyes funky-eyes requested review from caohdgege and slievrly and removed request for caohdgege February 6, 2023 13:32
@funky-eyes funky-eyes added the mode: AT AT transaction mode label Feb 6, 2023
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5307 (4ea0066) into develop (bf5586f) will increase coverage by 0.00%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5307   +/-   ##
==========================================
  Coverage      48.79%   48.80%           
+ Complexity      4178     4174    -4     
==========================================
  Files            743      743           
  Lines          26626    26619    -7     
  Branches        3333     3327    -6     
==========================================
- Hits           12992    12991    -1     
+ Misses         12229    12224    -5     
+ Partials        1405     1404    -1     
Impacted Files Coverage Δ
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 85.48% <75.00%> (+5.48%) ⬆️
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 77.07% <100.00%> (-0.57%) ⬇️
...erver/storage/file/session/FileSessionManager.java 47.77% <0.00%> (-0.64%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@funky-eyes funky-eyes requested a review from slievrly February 7, 2023 05:23
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants