Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix codecov chart not display #5828

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Sep 6, 2023

optimize: fix codecov

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #5828 (07d96a9) into develop (357f8e8) will decrease coverage by 0.61%.
Report is 65 commits behind head on develop.
The diff coverage is 54.97%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5828      +/-   ##
=============================================
- Coverage      48.79%   48.19%   -0.61%     
+ Complexity      4176     4122      -54     
=============================================
  Files            743      761      +18     
  Lines          26617    26769     +152     
  Branches        3327     3349      +22     
=============================================
- Hits           12989    12902      -87     
- Misses         12225    12454     +229     
- Partials        1403     1413      +10     
Files Changed Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...src/main/java/io/seata/common/aot/NativeUtils.java 0.00% <0.00%> (ø)
.../io/seata/common/loader/EnhancedServiceLoader.java 57.08% <0.00%> (-0.25%) ⬇️
...main/java/io/seata/common/util/ReflectionUtil.java 56.68% <0.00%> (-1.56%) ⬇️
...rc/main/java/io/seata/common/util/StringUtils.java 36.92% <0.00%> (ø)
...c/main/java/io/seata/config/FileConfiguration.java 46.82% <0.00%> (-0.28%) ⬇️
...eata/config/exception/ConfigNotFoundException.java 0.00% <0.00%> (ø)
...in/java/io/seata/config/file/SimpleFileConfig.java 30.76% <0.00%> (-5.60%) ⬇️
.../src/main/java/io/seata/core/constants/DBType.java 0.00% <0.00%> (ø)
... and 91 more

... and 48 files with indirect coverage changes

@wangliang181230 wangliang181230 changed the title Test codecov optimize: fix codecov Sep 6, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: fix codecov optimize: fix codecov chart not display Sep 6, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6bb865b into apache:develop Sep 6, 2023
@slievrly slievrly added this to the 1.8.0 milestone Sep 6, 2023
@wangliang181230 wangliang181230 deleted the test-codecov branch September 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants