-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add meta info to docker image #5842
optimize: add meta info to docker image #5842
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5842 +/- ##
============================================
+ Coverage 49.00% 49.03% +0.03%
- Complexity 4458 4465 +7
============================================
Files 821 821
Lines 28557 28557
Branches 3570 3570
============================================
+ Hits 13995 14004 +9
+ Misses 13102 13098 -4
+ Partials 1460 1455 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert to the docker hub registry.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Adding meta information to docker image,those information will be helpful for locating problems.
Ⅱ. Does this pull request fix one issue?
fixes #5653
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've tested it.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews