Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize change log #5905

Merged
merged 7 commits into from
Oct 7, 2023

Conversation

wangliang181230
Copy link
Contributor

optimize: optimize change log

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #5905 (cf4994e) into 2.x (9c4f0a6) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5905      +/-   ##
============================================
+ Coverage     48.71%   48.72%   +0.01%     
  Complexity     4428     4428              
============================================
  Files           819      819              
  Lines         28610    28610              
  Branches       3569     3569              
============================================
+ Hits          13936    13939       +3     
+ Misses        13214    13212       -2     
+ Partials       1460     1459       -1     

see 7 files with indirect coverage changes

@@ -80,7 +80,7 @@ jobs:
# step 4
- name: "Test with Maven"
run: |
./mvnw -T 4C clean test -Dspring-boot.version=${{ matrix.springboot }} -Dspring-boot-for-server.version=2.5.14 -Dspring-framework-for-server.version=5.3.20 -Dkotlin-maven-plugin.version=1.7.22 -Dcheckstyle.skip=false -Dlicense.skip=false -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
./mvnw -T 4C clean test -Dspring-boot.version=${{ matrix.springboot }} -Dspring-boot-for-server.version=2.5.14 -Dspring-framework-for-server.version=5.3.20 -Dkotlin-maven-plugin.version=1.7.22 -Dcheckstyle.skip=true -Dlicense.skip=true -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上次改错了。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 5c28eeb into apache:2.x Oct 7, 2023
7 checks passed
@wangliang181230 wangliang181230 deleted the optimize-change-log branch October 7, 2023 05:56
@wangliang181230 wangliang181230 added this to the Other Branchs milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants