test : Complete test cases for the (current-version) protocol by MessageType #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6207 +/- ##
============================================
- Coverage 49.03% 48.94% -0.09%
+ Complexity 4786 4778 -8
============================================
Files 915 915
Lines 31896 31896
Branches 3855 3855
============================================
- Hits 15641 15613 -28
- Misses 14699 14721 +22
- Partials 1556 1562 +6 |
1 task
xingfudeshi
reviewed
Dec 26, 2023
test/src/test/java/io/seata/core/rpc/netty/ChannelManagerTestHelper.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Dec 26, 2023
test/src/test/java/io/seata/core/rpc/netty/ChannelManagerTestHelper.java
Outdated
Show resolved
Hide resolved
|
建议把mockserver合完再合这个 #6205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Complete test cases for the (current-version) protocol by MessageType. This also provides the basis for comprehensive testing of multiple versions of the protocol.
Ⅱ. Does this pull request fix one issue?
fixes #6213
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews