-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: standardize Seata Exception #6269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test case can be added to see the specific exception logging style when ci is pipelined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve conflicting files |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6269 +/- ##
============================================
- Coverage 52.07% 52.01% -0.06%
- Complexity 5199 5207 +8
============================================
Files 921 925 +4
Lines 32140 32264 +124
Branches 3869 3887 +18
============================================
+ Hits 16737 16783 +46
- Misses 13779 13837 +58
- Partials 1624 1644 +20
|
Ⅰ. Describe what this PR did
standardize Seata Exception
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews