Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize Seata Exception #6269

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jan 17, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

standardize Seata Exception

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test case can be added to see the specific exception logging style when ci is pipelined

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

Please resolve conflicting files

@slievrly
Copy link
Member Author

slievrly commented Feb 4, 2024

A test case can be added to see the specific exception logging style when ci is pipelined

https://github.com/apache/incubator-seata/pull/6269/files#diff-1468ca2433d8757b616ee24c5869c2628e14526552a4f5b0fba07b04aee622dbR44

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Feb 18, 2024
@funky-eyes funky-eyes added the module/common common module label Feb 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (ee6f660) 52.07% compared to head (e202714) 52.01%.
Report is 18 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6269      +/-   ##
============================================
- Coverage     52.07%   52.01%   -0.06%     
- Complexity     5199     5207       +8     
============================================
  Files           921      925       +4     
  Lines         32140    32264     +124     
  Branches       3869     3887      +18     
============================================
+ Hits          16737    16783      +46     
- Misses        13779    13837      +58     
- Partials       1624     1644      +20     
Files Coverage Δ
...a/org/apache/seata/common/exception/ErrorCode.java 100.00% <100.00%> (ø)
...che/seata/common/exception/FrameworkErrorCode.java 94.44% <100.00%> (ø)
...common/exception/AbstractRemoteResourceBundle.java 0.00% <0.00%> (ø)
...che/seata/common/exception/ResourceBundleUtil.java 80.48% <80.48%> (ø)
.../seata/common/exception/SeataRuntimeException.java 12.50% <12.50%> (ø)

... and 34 files with indirect coverage changes

@xingfudeshi xingfudeshi merged commit ed41072 into apache:2.x Feb 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants