Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add jdbc class isolation loader for different versions #7032

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add jdbc class isolation loader for different versions

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (ca38b28) to head (d9ebfba).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% 37 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7032      +/-   ##
============================================
- Coverage     52.63%   52.59%   -0.05%     
- Complexity     6616     6618       +2     
============================================
  Files          1128     1128              
  Lines         40105    40140      +35     
  Branches       4704     4704              
============================================
+ Hits          21111    21112       +1     
- Misses        16983    17018      +35     
+ Partials       2011     2010       -1     
Files with missing lines Coverage Δ
...eata/core/store/db/AbstractDataSourceProvider.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 29, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 3b7e887 into apache:2.x Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants