Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feature:[loom] replace the usages of synchronized with ReentrantLock #7073

Open
wants to merge 7 commits into
base: 2.x
Choose a base branch
from

Conversation

lightClouds917
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

To use virtual threads in JDK 21, we need to remove the usage of synchronized to prevent the issue where "a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier."

Ⅱ. Does this pull request fix one issue?

fixes #6971

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 57.31707% with 35 lines in your changes missing coverage. Please review.

Project coverage is 52.67%. Comparing base (26950b6) to head (0142110).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/rm/datasource/xa/ConnectionProxyXA.java 43.33% 28 Missing and 6 partials ⚠️
...ache/seata/rm/datasource/xa/ResourceManagerXA.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7073      +/-   ##
============================================
+ Coverage     52.66%   52.67%   +0.01%     
- Complexity     6643     6649       +6     
============================================
  Files          1126     1127       +1     
  Lines         40142    40162      +20     
  Branches       4707     4712       +5     
============================================
+ Hits          21139    21155      +16     
- Misses        16990    16995       +5     
+ Partials       2013     2012       -1     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/lock/ResourceLock.java 100.00% <100.00%> (ø)
...va/org/apache/seata/common/util/UUIDGenerator.java 66.66% <100.00%> (ø)
.../integration/tx/api/fence/hook/TccHookManager.java 78.94% <100.00%> (ø)
.../tx/api/remoting/parser/DefaultRemotingParser.java 92.72% <100.00%> (+0.13%) ⬆️
...pache/seata/integration/tx/api/util/ProxyUtil.java 68.18% <100.00%> (+1.51%) ⬆️
...org/apache/seata/rm/datasource/util/JdbcUtils.java 8.34% <100.00%> (-0.07%) ⬇️
...a/integration/rocketmq/SeataMQProducerFactory.java 87.50% <100.00%> (+6.25%) ⬆️
...org/apache/seata/server/session/GlobalSession.java 69.85% <100.00%> (+0.11%) ⬆️
...ache/seata/rm/datasource/xa/ResourceManagerXA.java 21.21% <66.66%> (+0.31%) ⬆️
...ache/seata/rm/datasource/xa/ConnectionProxyXA.java 57.77% <43.33%> (+0.80%) ⬆️

... and 3 files with indirect coverage changes

@YvCeung
Copy link
Contributor

YvCeung commented Dec 26, 2024

Maybe not including * when importing the package would be more in line with programming standards.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: [loom] replace the usages of synchronized with ReentrantLock
2 participants