optimize: fast fail when channel is null #7075
Merged
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR enhances the
RmNettyRemotingClient#sendRegisterMessage
method by improving its error handling when thechannel
parameter isnull
.Ⅱ. Does this pull request fix one issue?
Fixes #7057
Ⅲ. Why don't you add test cases (unit test/integration test)?
org.apache.seata.core.rpc.netty.RmNettyClientTest#testSendAsyncRequestWithNullChannelLogsWarning
Ⅳ. Describe how to verify it
mvn test