Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10291][SDK] Fix incorrect initializing of gnet in Golang SDK #10294

Merged
merged 1 commit into from
May 29, 2024

Conversation

gunli
Copy link
Contributor

@gunli gunli commented May 28, 2024

Fixes #10291

Motivation

Currently, the initialization of gent.Client is incorrect, which will make it blocked when we upgrade gnet to v2.4.0 or later.

Modifications

  1. call gnet.Client.Start() after create it;
  2. bump up modules.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang merged commit d43e1e8 into apache:master May 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][SDK] Incorrect initializing of gnet in Golang SDK
4 participants