-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-10468][Dashboard] Audit data showing totals and variances #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
previously approved these changes
Jun 20, 2024
doleyzi
reviewed
Jun 20, 2024
Time can just display hour and minute. |
It is better to add a row about day summary information. |
doleyzi
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended that when displaying audit data on the page, log_ts should be displayed in the following format:
- Minute Audit: Reserved mm:ss
- Hourly Audit: Reserved yyyy-MM-dd HH
- Audit by day: Reserved yyyy-MM-dd
dockerzhang
approved these changes
Jun 24, 2024
doleyzi
approved these changes
Jun 24, 2024
wohainilaodou
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10468
Motivation
Audit data showing totals and variances.
Modifications
MINUTE
- 1 dayHOUR
- 3 daysDAY
- 7 daysVerifying this change
Before:
After:
Minute Audit
Hourly Audit
Audit by day