Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10468][Dashboard] Audit data showing totals and variances #10469

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

haifxu
Copy link
Contributor

@haifxu haifxu commented Jun 20, 2024

Fixes #10468

Motivation

Audit data showing totals and variances.

Modifications

  • Calculate the difference ratio between each column and the first column.
  • Calculate the sum of each column, including all pages.
  • Limit the date selection range based on time units.
    MINUTE - 1 day
    HOUR - 3 days
    DAY - 7 days
  • Add commas to audit data for easier reading.

Verifying this change

Before:
image

After:
image

Minute Audit
image
Hourly Audit
image
Audit by day
image

dockerzhang
dockerzhang previously approved these changes Jun 20, 2024
@luchunliang
Copy link
Contributor

Time can just display hour and minute.
Year/month/day/second can be removed

@luchunliang
Copy link
Contributor

It is better to add a row about day summary information.

Copy link
Contributor

@doleyzi doleyzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended that when displaying audit data on the page, log_ts should be displayed in the following format:

  1. Minute Audit: Reserved mm:ss
  2. Hourly Audit: Reserved yyyy-MM-dd HH
  3. Audit by day: Reserved yyyy-MM-dd

@dockerzhang dockerzhang merged commit 72671f5 into apache:master Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Dashboard] Audit data showing totals and variances
5 participants