Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10500][Dashboard] Change the visible range to a drop-down box #10502

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

wohainilaodou
Copy link
Contributor

@wohainilaodou wohainilaodou commented Jun 25, 2024

Fixes #10500

Motivation

When editing the template, select the visual range first, the visual range should be a drop-down selection box, if the visual range is tenant level, the tenant information needs to be filled, otherwise it is hidden

Modifications

if the visual range is tenant level, the tenant information needs to be filled, otherwise it is hidden, let the visual range be a drop-down selection box

Verifying this change

before:
image
after:
create
image
before:
if you select a tenant in the visual range drop-down selection box show the tenant list
image

change the list to show
before
image
after
image

@wohainilaodou wohainilaodou changed the title [INLONG-10500][Dashboard] When you edit tenants in a template, you ne… [INLONG-10500][Dashboard] Change the visible range to a drop-down box Jun 25, 2024
dockerzhang
dockerzhang previously approved these changes Jun 25, 2024
@wohainilaodou wohainilaodou marked this pull request as draft June 26, 2024 01:50
@wohainilaodou wohainilaodou marked this pull request as ready for review June 27, 2024 02:21
@dockerzhang dockerzhang merged commit 163fb5e into apache:master Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Dashboard] When you edit tenants in a template, you need to change the scope to hide them
3 participants