Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: return unmodifiableMap for PartitionStates.partitionStateMap #7637

Merged
merged 1 commit into from
Mar 19, 2020
Merged

MINOR: return unmodifiableMap for PartitionStates.partitionStateMap #7637

merged 1 commit into from
Mar 19, 2020

Conversation

lbradstreet
Copy link
Contributor

Discussion #7576 (comment). Makes the map returned by partitionStateMap unmodifiable to prevent mutation.

@lbradstreet
Copy link
Contributor Author

cc @ijuma

@mumrah
Copy link
Member

mumrah commented Mar 10, 2020

retest this please

ijuma
ijuma approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ijuma
ijuma approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma ijuma merged commit 5c0cf02 into apache:trunk Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijuma ijuma ijuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbradstreet @mumrah @ijuma