KNOX-2979 - Removed redundant 'refresh' query parameter from the appl…

…ication logout link after originalUrl (#815)
apache · Oct 31, 2023 · d569373 · d569373
1 parent 6ec81a0
commit d569373
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/gateway-applications/src/main/resources/applications/knoxauth/app/logout.jsp b/gateway-applications/src/main/resources/applications/knoxauth/app/logout.jsp
@@ -90,17 +90,13 @@
 
         boolean validRedirect = false;
         String origUrl = request.getParameter("originalUrl");
-        String del = "?";
-        if (origUrl != null && origUrl.contains("?")) {
-          del = "&";
-        }
         if (origUrl != null) {
           validRedirect = RegExUtils.checkWhitelist(whitelist, origUrl);
         }
         if (("1".equals(request.getParameter("returnToApp")))) {
           if (validRedirect) {
-          	response.setStatus(HttpServletResponse.SC_MOVED_PERMANENTLY);
-          	response.setHeader("Location",originalUrl + del + "refresh=1");
+            response.setStatus(HttpServletResponse.SC_MOVED_PERMANENTLY);
+            response.setHeader("Location", originalUrl);
             return;
           }
         }

diff --git a/knox-homepage-ui/home/app/homepage.service.ts b/knox-homepage-ui/home/app/homepage.service.ts
@@ -132,20 +132,6 @@ export class HomepageService {
     }
 
     private handleError(error: HttpErrorResponse): Promise<any> {
-        // location.reload();
-        let refresh;
-        this.route.queryParams.subscribe(params => {
-          refresh = params['refresh'];
-          console.debug('refresh = ' + refresh);
-          if (refresh) {
-            console.debug('Refreshing page...', window.location.href);
-            let url = window.location.pathname.replace(new RegExp('refresh=1/.*'), '?');
-            // var url = window.location.pathname;
-
-            // window.location.assign(url);
-            window.location.reload();
-          }
-        });
         Swal.fire({
             icon: 'error',
             title: 'Oops!',