KNOX-2455 - Upgrade Shiro to 1.6.0 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to upgrade Shiro library to 1.6.0. Shiro 1.6.0 introduces some drastic changes in response to a security issue (see Global Filters) these changes will break some of the proxying services that include
;\in the URL.;is most commonly used forjsessionidso that likely will introduce some breakage. We try to mitigate this breakage by turning off blocking;,\and non-ascii characters by setting the following properties to false out of the box.invalidRequest.blockBackslash = falseinvalidRequest.blockSemicolon = falseinvalidRequest.blockNonAscii = falseThese properties can be set to true in Knox topology (by adding shiro providers param section).
This PR also adds unit tests to test these changes.
How was this patch tested?
This patch was tested locally.