Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2962 - Knox readiness check gateway-status endpoint should return the list of topologies for which it is waiting for #800

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

zeroflag
Copy link
Contributor

@zeroflag zeroflag commented Oct 9, 2023

What changes were proposed in this pull request?

The gateway-status requests returns the list of pending topologies.

How was this patch tested?

Added health topology:

<topology>
    <gateway>
        <provider>
            <role>authentication</role>
            <name>Anonymous</name>
            <enabled>true</enabled>
        </provider>
    </gateway>
    <service>
        <role>HEALTH</role>
    </service>
</topology>

and 2 invalid descriptors: test.json and test2.json

$ curl -vk https://localhost:8443/gateway/health/v1/gateway-status

Output

< HTTP/1.1 200 OK
< Date: Mon, 09 Oct 2023 10:36:50 GMT
< Cache-Control: must-revalidate,no-cache,no-store
< Content-Type: text/plain;charset=iso-8859-1
< Content-Length: 23
< 
PENDING: [test2, test]

…n the list of topologies for which it is waiting for
@zeroflag zeroflag marked this pull request as draft October 9, 2023 10:23
@zeroflag zeroflag self-assigned this Oct 9, 2023
@zeroflag zeroflag marked this pull request as ready for review October 9, 2023 10:39
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroflag zeroflag merged commit ff6bcbc into apache:master Oct 11, 2023
2 checks passed
zeroflag added a commit that referenced this pull request Oct 11, 2023
…ld return the list of topologies for which it is waiting for (#800)"

This reverts commit ff6bcbc.
zeroflag added a commit that referenced this pull request Oct 11, 2023
…ld return the list of topologies for which it is waiting for (#800)" (#803)

This reverts commit ff6bcbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants