Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.shiro:shiro-core from 1.10.0 to 1.13.0 #853

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2024

Bumps org.apache.shiro:shiro-core from 1.10.0 to 1.13.0.

Release notes

Sourced from org.apache.shiro:shiro-core's releases.

Apache Shiro 1.13.0

What's Changed

Full Changelog: apache/shiro@shiro-root-1.12.0...shiro-root-1.13.0

shiro-root-1.12.0

What's Changed

... (truncated)

Commits
  • 8681958 [maven-release-plugin] prepare release shiro-root-1.13.0
  • f4daf3a Merge pull request #1148 from apache/dependabot/maven/1.13.x/com.ibm.icu-icu4...
  • 02e1f66 build(deps): bump com.ibm.icu:icu4j from 73.2 to 74.1
  • d62387d Add tests for SavedRequest redirects
  • 3b80f5c The InvalidRequestFilter is more flexible
  • 443135b Revert "[maven-release-plugin] prepare release shiro-root-1.13.0"
  • 208e0b8 Revert "[maven-release-plugin] prepare for next development iteration"
  • e4c217c [maven-release-plugin] prepare for next development iteration
  • fb46976 [maven-release-plugin] prepare release shiro-root-1.13.0
  • 4e71c79 Merge pull request #1144 from fpapon/SHIRO-1143
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 27, 2024
@lmccay
Copy link
Contributor

lmccay commented Oct 20, 2024

@dependabot rebase

Bumps [org.apache.shiro:shiro-core](https://github.com/apache/shiro) from 1.10.0 to 1.13.0.
- [Release notes](https://github.com/apache/shiro/releases)
- [Changelog](https://github.com/apache/shiro/blob/main/RELEASE-NOTES)
- [Commits](apache/shiro@shiro-root-1.10.0...shiro-root-1.13.0)

---
updated-dependencies:
- dependency-name: org.apache.shiro:shiro-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.apache.shiro-shiro-core-1.13.0 branch from fab6f22 to a8dd919 Compare October 20, 2024 18:43
@lmccay
Copy link
Contributor

lmccay commented Oct 20, 2024

This results in a failure of expected http status code in GatewayBasicFuncTest.testEncodedForwardSlash:

Error: Tests run: 43, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 22.628 s <<< FAILURE! - in org.apache.knox.gateway.GatewayBasicFuncTest
Error: testEncodedForwardSlash(org.apache.knox.gateway.GatewayBasicFuncTest) Time elapsed: 0.015 s <<< FAILURE!
java.lang.AssertionError: expected:<200> but was:<400>
at org.apache.knox.gateway.GatewayBasicFuncTest.testEncodedForwardSlash(GatewayBasicFuncTest.java:1712)

[INFO]
[INFO] Results:
[INFO]
Error: Failures:
Error: GatewayBasicFuncTest.testEncodedForwardSlash:1712 expected:<200> but was:<400>
[INFO]
Error: Tests run: 44, Failures: 1, Errors: 0, Skipped: 0

@lmccay
Copy link
Contributor

lmccay commented Oct 20, 2024

Same change works fine for me locally. I am going to merge it and watch for problems.

@lmccay lmccay merged commit 9e34610 into master Oct 20, 2024
0 of 2 checks passed
@dependabot dependabot bot deleted the dependabot/maven/org.apache.shiro-shiro-core-1.13.0 branch October 20, 2024 19:58
lmccay pushed a commit to lmccay/knox that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant