KNOX-3018 - Tokens that never expire should not be evicted automatically and their expiration should be displayed properly #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly and their expiration should be displayed properly
zeroflag
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
Token ManagementandToken GenerationUIs are updated in a way such that they displayNever expiresin case a token never expires (that is, if the token's expiration is set to a negative number).Moreover, the automated token eviction logic is modified to never remove those tokens from the underlying token state backend.
How was this patch tested?
Updated existing unit tests to cover the token eviction logic change and ran manual testing on the UI.