KNOX-3064: Set the private gatewayservices field to fix nullpointer e… #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzampino
reviewed
Sep 10, 2024
moresandeep
approved these changes
Sep 10, 2024
|
No, locally it is working fine. The builds are failing on GitHub. |
Ship it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xceptions
What changes were proposed in this pull request?
The below tests are failing with NullPointerException during the build
BadUrlTest.setUpBeforeClass:122->startGatewayServer:180->setupGatewayConfig:321 » NullPointer
WebsocketBackendUrlTest.setUpBeforeClass:59->WebsocketEchoTestBase.setupGatewayConfig:351 » NullPointer
WebsocketEchoHTTPServiceRoleTest.setUpBeforeClass:64->WebsocketEchoTestBase.startServers:116->WebsocketEchoTestBase.startServers:121->WebsocketEchoTestBase.startGatewayServer:206->WebsocketEchoTestBase.setupGatewayConfig:351 » NullPointer
WebsocketEchoTest.setUpBeforeClass:63->WebsocketEchoTestBase.startServers:116->WebsocketEchoTestBase.startServers:121->WebsocketEchoTestBase.startGatewayServer:206->WebsocketEchoTestBase.setupGatewayConfig:351 » NullPointer
WebsocketMultipleConnectionTest.startServers:131->startGatewayServer:239->setupGatewayConfig:384 » NullPointer
WebsocketServerInitiatedMessageTest.setUpBeforeClass:73->WebsocketEchoTestBase.startServers:116->WebsocketEchoTestBase.startServers:121->WebsocketEchoTestBase.startGatewayServer:206->WebsocketEchoTestBase.setupGatewayConfig:351 » NullPointer
WebsocketServerInitiatedPingTest.setUpBeforeClass:75->WebsocketEchoTestBase.startServers:116->WebsocketEchoTestBase.startServers:121->WebsocketEchoTestBase.startGatewayServer:206->WebsocketEchoTestBase.setupGatewayConfig:351 » NullPointer
The changes address these NullPointerExceptions thrown.
How was this patch tested?
Ran tests locally
Github build also successfully completed with these changes in my repository