KNOX-3067: Upgrade ehcache to 3.3.1 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moresandeep
requested changes
Oct 4, 2024
gateway-provider-security-shiro/src/main/java/org/apache/knox/gateway/ShiroMessages.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private synchronized org.ehcache.Cache<Object, Object> createCache(String name) |
There was a problem hiding this comment.
Why are we synchronizing?
There was a problem hiding this comment.
The implementation is based on the 2.x CacheManager. In our use-case there is no race condition currently however future changes might introduce. The synchronized block doesn't slow Knox's start-up because there is no contention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade ehcache from 2.x to 3.x
Currently with 2.x the CacheManager is a Singleton therefore every cache will be stored in the same CacheManager. Due to this caches with the same name will be created only once and different topologies are using the same cache. For example if a user authenticates in the sandbox topology the same user and password can be used for other topologies as well where ehcache is enabled and the cache name is the same. This could cause issues if the ldap configuration is different.
With Ehcache 3.x creating the CacheManager is our responsibility. Different topologies will have different configurations and caches even with the same name. Every topology that enables ehcache needs a different configuration file. The persistence attribute has to be unique.
How was this patch tested?
Unit tests and manually on local setup