KNOX-3074: Add hbase ui service config and rewrite rules for jsp pages missing in HBase v2.5.10 #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for HBase v2.5
|
Hi @tr0k ! Please attach some screenshots of the JSP pages you are proxying through Knox (you may want to blur sensitive content). |
|
Hi @smolnar82, I am attaching here some example pages such as hbase/webui/master/table.jsp?host&port&name=my_table
|
smolnar82
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
LGTM
I like that you created the new v2.5.
@moresandeep - Could you please take a look?
|
Cc. @stoty - It'd be nice if you could also look at this new version. Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
New service.xml and rewrite.xml configuration for HBase UI v2.5.10.
For example /table.jsp or /userSnapshots.jsp rules are currently missing for the latest stable release of HBase
How was this patch tested?
Tested locally on the CERN clusters against HBase UI v2.5.10 with Knox v2.