Support logging to stderr #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ColinChamber #478 wishes to put log to stdout instead of stderr. |
|
Let's wait for the glog release.google/glog#790 @ShooterIT |
|
@ColinChamber Can use the RC version |
|
OK, i notice new version will be released at April 1🥳 |
|
google-glog 0.6.0-rc2. I need to modify the Makefile and CMakeLists.txt @git-hulk |
|
why we need to modify those files? |
|
The way glog is built has changed. |
Kvrocks Makefile and CMakeLists.txt |
|
@ColinChamber glog 0.6 is released, you can push this forward 🥳 |
|
@ColinChamber Do you have time to finish this feature? If no, I can move on. |
|
Will close this PR since we handled it in the new PR #613, thanks for @ColinChamber efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #478