[KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Kyuubi 1.6.0
github-actions
bot
added
kind:documentation
…to Kyuubi 1.6.0
pan3793
reviewed
Nov 7, 2022
docs/deployment/migration-guide.md
Outdated
| * Since Kyuubi 1.7, Kyuubi returns engine's information for `GetInfo` request instead of server. To restore the previous behavior, set `kyuubi.server.info.provider` to `SERVER`. | ||
| * Since Kyuubi 1.7, Kyuubi returns engine's information for `GetInfo` request instead of server. | ||
| To restore the previous behavior, set `kyuubi.server.info.provider` to `SERVER`. | ||
| * Since Kyuubi 1.7, `kyuubi.kinit.principal` & `kyuubi.kinit.keytab` are filtered out from Kyuubi engine's conf for better security. |
…to Kyuubi 1.6.0
…to Kyuubi 1.6.0
…to Kyuubi 1.6.0
pan3793
reviewed
Nov 7, 2022
docs/deployment/migration-guide.md
Outdated
| When Kyuubi engine does kerberos authentication with zookeeper, user needs to explicitly set `kyuubi.ha.zookeeper.engine.auth.type` to `KERBEROS`. | ||
|
|
||
| ## Upgrading from Kyuubi 1.5 to 1.6 | ||
| * Kyuubi engine get zookeeper principal & keytab from `kyuubi.ha.zookeeper.auth.principal` & `kyuubi.ha.zookeeper.auth.keytab`. |
pan3793
approved these changes
Nov 7, 2022
…to Kyuubi 1.6.0
Codecov Report
@@ Coverage Diff @@
## master #3771 +/- ##
============================================
+ Coverage 51.93% 52.62% +0.69%
Complexity 13 13
============================================
Files 484 494 +10
Lines 27122 27799 +677
Branches 3784 3835 +51
============================================
+ Hits 14086 14630 +544
- Misses 11669 11773 +104
- Partials 1367 1396 +29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhouyifan279
commented
Nov 7, 2022
| .fallbackConf(HA_ZK_AUTH_TYPE) | ||
| .stringConf | ||
| .checkValues(AuthTypes.values.map(_.toString)) | ||
| .createWithDefault(AuthTypes.NONE.toString) |
There was a problem hiding this comment.
Engine defaults to access Zookeeper without authentication
…to Kyuubi 1.6.0
cxzl25
approved these changes
Nov 7, 2022
pan3793
approved these changes
Nov 7, 2022
|
Thanks, merigng to master/1.6 |
pan3793
pushed a commit
that referenced
this pull request
Nov 7, 2022
…ubi 1.6.0 Fix #3744 - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3771 from zhouyifan279/3744. Closes #3744 5876429 [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 554e889 [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 a6bfa3d [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 c90470f [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 fe55f4a [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 e262872 [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 ed5e8bd [zhouyifan279] [KYUUBI #3744][Bug] InvalidACL appears in engine after upgrade to Kyuubi 1.6.0 Authored-by: zhouyifan279 <zhouyifan279@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix #3744
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request